From patchwork Fri Feb 25 00:27:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Trebbien X-Patchwork-Id: 84498 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9EC75B70A5 for ; Fri, 25 Feb 2011 11:28:40 +1100 (EST) Received: from localhost ([127.0.0.1]:43833 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PslXf-0007pE-M0 for incoming@patchwork.ozlabs.org; Thu, 24 Feb 2011 19:28:19 -0500 Received: from [140.186.70.92] (port=39598 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PslWt-0007lw-21 for qemu-devel@nongnu.org; Thu, 24 Feb 2011 19:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PslWr-0003Jn-Pf for qemu-devel@nongnu.org; Thu, 24 Feb 2011 19:27:30 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:34070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PslWr-0003Ji-HN for qemu-devel@nongnu.org; Thu, 24 Feb 2011 19:27:29 -0500 Received: by pzk3 with SMTP id 3so217285pzk.4 for ; Thu, 24 Feb 2011 16:27:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=561q5hoHYOO+vyH1IkppsCVlcLyX1vWBbNODRS8xQms=; b=wGTCQrj0S/yvGPkn0wLc08eD3ZTDCUwhki4pDVmsz/cchnMdGDbMty6WWAXnIKHxYS m1LiilnxCv3chLHZwLC+71q33M8GgvA8zwaTkYs2m19v6CDjVicGNfRBY1JvB4s/SrSa 4f0F4LR0eTfxCanYJuV+G84K5yK+mYxcCJyDY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=q430XBFG6eNYZ2L1/6Ke2wSOq//5rucYu+eOjIPlJLwYXxYLoB49uE/SKoM2KfOkBq hYYyw+OMVGWBx2u4uKgY3CMwYQLHf+r91coHhY2c7gtCt8FAKvog5eIEF8smPBDRDWq5 wOEPTEolICU4XyXlssspx5KBkZBD/9BWB1ZfI= MIME-Version: 1.0 Received: by 10.142.155.9 with SMTP id c9mr1182893wfe.127.1298593647557; Thu, 24 Feb 2011 16:27:27 -0800 (PST) Received: by 10.142.58.16 with HTTP; Thu, 24 Feb 2011 16:27:27 -0800 (PST) Date: Thu, 24 Feb 2011 16:27:27 -0800 Message-ID: From: Joey Trebbien To: qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.45 Subject: [Qemu-devel] [PATCH] Outdated comment in HACKING X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org All printf-style functions in the source (except for a few in tests/) already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR macros). Signed-off-by: Joseph Trebbien --- HACKING | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/HACKING b/HACKING index 6ba9d7e..3af53fd 100644 --- a/HACKING +++ b/HACKING @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. This makes it so gcc's -Wformat and -Wformat-security options can do their jobs and cross-check format strings with the number and types of arguments. - -Currently many functions in QEMU are not following this rule but -patches to add the attribute would be very much appreciated.