diff mbox series

bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()

Message ID 20171205143752.cymsw7fzlqn6ejeq@mwanda
State Accepted, archived
Delegated to: David Miller
Headers show
Series bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() | expand

Commit Message

Dan Carpenter Dec. 5, 2017, 2:37 p.m. UTC 
Smatch warns that:

    drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
    error: uninitialized symbol 'rc'.

"rc" is either uninitialized or set to zero here so we can just remove
the check.

Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Dan Carpenter Dec. 5, 2017, 2:43 p.m. UTC | #1 
I'm sorry, I left out that this applies to net-next.

regards,
dan carpenter
David Miller Dec. 6, 2017, 7 p.m. UTC | #2 
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 5 Dec 2017 17:37:52 +0300

> Smatch warns that:
> 
>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>     error: uninitialized symbol 'rc'.
> 
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
> 
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Michael, please review.

Thanks.
Michael Chan Dec. 6, 2017, 7:16 p.m. UTC | #3 
On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch warns that:
>
>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>     error: uninitialized symbol 'rc'.
>
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks.

Acked-by: Michael Chan <michael.chan@broadcom.com>
David Miller Dec. 6, 2017, 7:25 p.m. UTC | #4 
From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 6 Dec 2017 11:16:55 -0800

> On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> Smatch warns that:
>>
>>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>>     error: uninitialized symbol 'rc'.
>>
>> "rc" is either uninitialized or set to zero here so we can just remove
>> the check.
>>
>> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Thanks.
> 
> Acked-by: Michael Chan <michael.chan@broadcom.com>

Applied to net-next, thanks everyone.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index d5031f436f83..125b146da031 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -157,9 +157,6 @@  static int bnxt_tc_parse_actions(struct bnxt *bp,
 		}
 	}
 
-	if (rc)
-		return rc;
-
 	/* Tunnel encap/decap action must be accompanied by a redirect action */
 	if ((actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP ||
 	     actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_DECAP) &&
@@ -169,7 +166,7 @@  static int bnxt_tc_parse_actions(struct bnxt *bp,
 		return -EINVAL;
 	}
 
-	return rc;
+	return 0;
 }
 
 #define GET_KEY(flow_cmd, key_type)					\