diff mbox series

[v2,2/5] ARM: dts: imx53: add srtc node

Message ID 20171205140646.30367-3-linux-kernel-dev@beckhoff.com
State Superseded
Headers show
Series add mxc driver for i.MX53 SRTC | expand

Commit Message

linux-kernel-dev Dec. 5, 2017, 2:06 p.m. UTC
From: Patrick Bruenn <p.bruenn@beckhoff.com>

rtc-mxc_v2 driver will add support for the i.MX53 SRTC

Signed-off-by: Patrick Bruenn <p.bruenn@beckhoff.com>

---

To: Shawn Guo <shawnguo@kernel.org>
To: Sascha Hauer <kernel@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: linux-rtc@vger.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM)
Cc: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Cc: linux-kernel@vger.kernel.org (open list)
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Juergen Borleis <jbe@pengutronix.de>
Cc: Noel Vellemans <Noel.Vellemans@visionbms.com>
Cc: Russell King <linux@armlinux.org.uk> (maintainer:ARM PORT)
Cc: linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)

Cc: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Lothar Waßmann <LW@KARO-electronics.de>
---
 arch/arm/boot/dts/imx53.dtsi | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Fabio Estevam Dec. 5, 2017, 2:13 p.m. UTC | #1
On Tue, Dec 5, 2017 at 12:06 PM,  <linux-kernel-dev@beckhoff.com> wrote:

>                         srtc: srtc@53fa4000 {
> -                               compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
> +                               compatible = "fsl,imx53-rtc";
>                                 reg = <0x53fa4000 0x4000>;
>                                 interrupts = <24>;
> -                               interrupt-parent = <&tzic>;
>                                 clocks = <&clks IMX5_CLK_SRTC_GATE>;
> -                               clock-names = "ipg";

srtc node has been removed in linux-next.

You need to re-add it.
Patrick Brünn Dec. 5, 2017, 2:20 p.m. UTC | #2
>From: Fabio Estevam [mailto:festevam@gmail.com]

>Sent: Dienstag, 5. Dezember 2017 15:14

>On Tue, Dec 5, 2017 at 12:06 PM,  <linux-kernel-dev@beckhoff.com> wrote:

>

>>                         srtc: srtc@53fa4000 {

>> -                               compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";

>> +                               compatible = "fsl,imx53-rtc";

>>                                 reg = <0x53fa4000 0x4000>;

>>                                 interrupts = <24>;

>> -                               interrupt-parent = <&tzic>;

>>                                 clocks = <&clks IMX5_CLK_SRTC_GATE>;

>> -                               clock-names = "ipg";

>

>srtc node has been removed in linux-next.

>

>You need to re-add it.

Thanks for this super-fast responses!
I will wait a few days for more reviewers and then integrate your comments in a v3. If nothing major show up I will wait until the imx53.dtsi revert landed in Linus tree.

Best regards,
Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
Fabio Estevam Dec. 10, 2017, 7:03 p.m. UTC | #3
On Tue, Dec 5, 2017 at 12:20 PM, Patrick Brünn <P.Bruenn@beckhoff.com> wrote:

> I will wait a few days for more reviewers and then integrate your comments in a v3. If nothing major show up I will wait until the imx53.dtsi revert landed in Linus tree.

It is in Linus' tree now as commit e501506d3ea0 ("Revert "ARM: dts:
imx53: add srtc node"").
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 589a67c5f796..e4ca9d9ba2fe 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -434,12 +434,10 @@ 
 			};
 
 			srtc: srtc@53fa4000 {
-				compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
+				compatible = "fsl,imx53-rtc";
 				reg = <0x53fa4000 0x4000>;
 				interrupts = <24>;
-				interrupt-parent = <&tzic>;
 				clocks = <&clks IMX5_CLK_SRTC_GATE>;
-				clock-names = "ipg";
 			};
 
 			iomuxc: iomuxc@53fa8000 {