[U-Boot,v2,04/16] efi: Add a TODO to efi_init_obj_list()

Message ID 20171204212832.130100-5-sjg@chromium.org
State Superseded
Delegated to: Alexander Graf
Headers show
  • efi: Enable basic sandbox support for EFI loader
Related show

Commit Message

Simon Glass Dec. 4, 2017, 9:28 p.m.
This function repeats data structures provided by driver model. They are
only created once so can be stale if the EFI loader is called twice (e.g.
for testing or on boot failure).

Add a TODO to address this. It should be possible to attach EFI devices
and data structures to driver-model devices and avoid having a parallel
set of data structures.

Signed-off-by: Simon Glass <sjg@chromium.org>

Changes in v2: None

 cmd/bootefi.c | 4 ++++
 1 file changed, 4 insertions(+)


diff --git a/cmd/bootefi.c b/cmd/bootefi.c
index a2138f6075..a4686f17f0 100644
--- a/cmd/bootefi.c
+++ b/cmd/bootefi.c
@@ -28,6 +28,10 @@  static struct efi_device_path *bootefi_device_path;
  * efi_init_obj_list() - Initialize and populate EFI object list
+ * TODO(sjg@chromium.org): Move this to a dynamic list based on driver model,
+ * so that it does not need to be created before running EFI applications
+ * and updates when devices change.
+ *
  * @return 0 if OK, -ve on error (in which case it prints a message)
 static efi_status_t efi_init_obj_list(void)