[U-Boot] efi_stub: Fix GDT_NOTSYS check

Message ID 20171204153326.8232-1-agraf@suse.de
State New
Delegated to: Alexander Graf
Headers show
Series
  • [U-Boot] efi_stub: Fix GDT_NOTSYS check
Related show

Commit Message

Alexander Graf Dec. 4, 2017, 3:33 p.m.
The get_codeseg32() wants to know if a passed in descriptor has
flag GDT_NOTSYS set (desc & GDT_NOTSYS), not whether desc and
GDT_NOTSYS are not != 0 (desk && GDT_NOTSYS).

This is an obvious typo. Fix it up.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 lib/efi/efi_stub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Dec. 4, 2017, 11:20 p.m. | #1
On Mon, Dec 4, 2017 at 11:33 PM, Alexander Graf <agraf@suse.de> wrote:
> The get_codeseg32() wants to know if a passed in descriptor has
> flag GDT_NOTSYS set (desc & GDT_NOTSYS), not whether desc and
> GDT_NOTSYS are not != 0 (desk && GDT_NOTSYS).
>
> This is an obvious typo. Fix it up.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  lib/efi/efi_stub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Patch

diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c
index 1814960572..9788dedba7 100644
--- a/lib/efi/efi_stub.c
+++ b/lib/efi/efi_stub.c
@@ -182,7 +182,7 @@  static int get_codeseg32(void)
 				<< 16;
 		base <<= 12;	/* 4KB granularity */
 		limit <<= 12;
-		if ((desc & GDT_PRESENT) && (desc && GDT_NOTSYS) &&
+		if ((desc & GDT_PRESENT) && (desc & GDT_NOTSYS) &&
 		    !(desc & GDT_LONG) && (desc & GDT_4KB) &&
 		    (desc & GDT_32BIT) && (desc & GDT_CODE) &&
 		    CONFIG_SYS_TEXT_BASE > base &&