From patchwork Sun Dec 3 21:03:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierluigi Passaro X-Patchwork-Id: 844011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:400c:c05::238; helo=mail-vk0-x238.google.com; envelope-from=swupdate+bncbd34zg6eryhrbo6nshiqkgqecbyv2ky@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="sk8dH43+"; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="I4ERwtj9"; dkim-atps=neutral Received: from mail-vk0-x238.google.com (mail-vk0-x238.google.com [IPv6:2607:f8b0:400c:c05::238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yqgV74v8Cz9rxl for ; Mon, 4 Dec 2017 08:03:58 +1100 (AEDT) Received: by mail-vk0-x238.google.com with SMTP id t14sf6521999vkc.19 for ; Sun, 03 Dec 2017 13:03:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:date:from:to:message-id:subject:mime-version :x-original-sender:precedence:mailing-list:list-id:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=NCcYR+opK6Lvi1kXzBFZ8sneNUky/aCxmUFKshv5s9o=; b=sk8dH43+buM9i7MQIfNIUyWW05MzNgifySWdgbZythjK8pJDuUvrf/74O+4zd0S5Le dGKHhOlaJUCz7uL+aZ4Fn/y4PyrVibCpEhzSibJ5Jhym7CT1Ov/uCvcO3P40J3nwrVNl AjiLbkn9j+bGY5tfAh3OZ47Z+DopwoIZbi1jygXCxceCVlq/SOp8MuXaa/P+J5dNJK6u Who7qh84cgsmLSwocuBjWiuZVFJfWGJGj6ScdEM6zd6BMNuTNeXTNsaf6+pxE8h3Qto1 hcthYhR91q8ICdjPrsRP/pIZKSb96qCfGaGpGqf9dohPk9P4xeguAwmq66qdifCACbHr fsew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:message-id:subject:mime-version:x-original-sender :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=NCcYR+opK6Lvi1kXzBFZ8sneNUky/aCxmUFKshv5s9o=; b=I4ERwtj95E+FFHmSASMr/Udh5YvT0+p7T0m+0APqckw3i2X6KOIEiyEhCJqaSGTIKh K7tesw07fBBuKf/ECJM/I10L4HNlEN8+p/JaXsvD2zgidUeyle7m3/0PSpF4DoLQ4dGd 4FiP3zggXVxPWTOfV6UcF04m/u8KaJQHMjkiiIvi89oU23E1X9FB7dDNT6/B+1esjICK pNKi16/HpVH1lLG1/FgN0gXy3595igLIaBCkOpwx8TWKQGe7aW0xjJCwT1UMkTyeLIJg AMSos+kFn3NdhJhvVqhM7hYvpSn911eT3lNm+BtfzlxyJIwoRMfaEVWiAgpQfWqyH4tW grjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:date:from:to:message-id:subject :mime-version:x-original-sender:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=NCcYR+opK6Lvi1kXzBFZ8sneNUky/aCxmUFKshv5s9o=; b=Nch+JHHLmlhXqUZcohsLMNpVfO91frclARW8ieWW4XX86WKeBdUP4LNRANezTo7NdM wNPaUPXhuIi8k5IAblhmoUgsMe4Sd81zw3xUMA49SriNlO3Sti4oOdM1Rr0dKuRp2lsq 5kPbpUjsFlXFZtm4xHbASsLKolKohXa5gEwbB95QXGiPzA04BIS2x6cS+8PgszS4ksQV 2GwR5KH8YUdqtEQU6cpc93pFaoTXzlP8MJC/e6Ubxu1u8b5NxyTwwDnG+M6NyUwiiuqP Y+3jY9LJhr4hc6e+br43uzh6DxXexxwqM+HE3okWsq7WdTJtNOCIDbfk4wPp2h9OldMH VoLA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AKGB3mLf4s/1F0isEkLRQ90PiqrYCVm/3U3ceA8TqW3AleATw7mGuD59 HI57cSCgtI/gIqE9eYONavg= X-Google-Smtp-Source: AGs4zMaa/qdn668M3zcyaj3XykprhQFJRw1dgzXYEMV2nDRvJFKcSNd6IWAqZzg/fDmZ1yYivg9Maw== X-Received: by 10.31.2.148 with SMTP id 142mr974553vkc.1.1512335035830; Sun, 03 Dec 2017 13:03:55 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 10.159.56.109 with SMTP id q42ls358141uad.10.gmail; Sun, 03 Dec 2017 13:03:55 -0800 (PST) X-Received: by 10.31.153.216 with SMTP id b207mr976556vke.8.1512335035009; Sun, 03 Dec 2017 13:03:55 -0800 (PST) Date: Sun, 3 Dec 2017 13:03:54 -0800 (PST) From: pierluigi.passaro@gmail.com To: swupdate Message-Id: <2480362c-150e-4ec4-a32e-9bbe47619112@googlegroups.com> Subject: [swupdate] [PATCH] archive handler: fix suid/sgid flags management MIME-Version: 1.0 X-Original-Sender: pierluigi.passaro@gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From b9085488b96e3a1984b6cea0a8fbbabe1dd446ce Mon Sep 17 00:00:00 2001 From: Pierluigi Passaro Date: Sun, 3 Dec 2017 21:40:26 +0100 Subject: [PATCH 1/1] archive handler: fix suid/sgid flags management archive handler calls libarchive with flags set to zero, missing the correct management of suid/sgid flags. Set flags to ARCHIVE_EXTRACT_PERM | ARCHIVE_EXTRACT_OWNER to fix it. Signed-off-by: Pierluigi Passaro --- handlers/archive_handler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/handlers/archive_handler.c b/handlers/archive_handler.c index ceb60a3..f4821b7 100644 --- a/handlers/archive_handler.c +++ b/handlers/archive_handler.c @@ -210,7 +210,7 @@ static int install_archive_image(struct img_type *img, TRACE("Installing file %s on %s\n", img->fname, path); - tf.flags = 0; + tf.flags = ARCHIVE_EXTRACT_PERM | ARCHIVE_EXTRACT_OWNER; ret = pthread_create(&extract_thread, &attr, extract, &tf); if (ret) {