diff mbox series

uboot-tools: fix dtc invocation

Message ID 20171201073027.23072-1-yegorslists@googlemail.com
State Superseded
Headers show
Series uboot-tools: fix dtc invocation | expand

Commit Message

Yegor Yefremov Dec. 1, 2017, 7:30 a.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

In Buildroot we don't perform Kconfig configuration for
u-boot-tools, hence CONFIG_MKIMAGE_DTC_PATH is empty.

Specify MKIMAGE_DTC as "dtc" to restore previous behavior.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 .../0005-Specify-dtc-binary-statically.patch       | 31 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/uboot-tools/0005-Specify-dtc-binary-statically.patch

Comments

Thomas Petazzoni Dec. 1, 2017, 8:52 a.m. UTC | #1 
Hello,

On Fri,  1 Dec 2017 08:30:27 +0100, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> In Buildroot we don't perform Kconfig configuration for
> u-boot-tools, hence CONFIG_MKIMAGE_DTC_PATH is empty.

Should we do a Kconfig configuration ?

Or alternatively, can we pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build
command line ?

Also: is this broken in master ? In next ? What is this fixing ? (Note:
I know all of this because we discussed it on IRC, but it should be in
the commit log).

Best regards,

Thomas
Yegor Yefremov Dec. 1, 2017, 9:44 a.m. UTC | #2 
Hi Thomas,

On Fri, Dec 1, 2017 at 9:52 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri,  1 Dec 2017 08:30:27 +0100, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> In Buildroot we don't perform Kconfig configuration for
>> u-boot-tools, hence CONFIG_MKIMAGE_DTC_PATH is empty.
>
> Should we do a Kconfig configuration ?
>
> Or alternatively, can we pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build
> command line ?

I'll try this :-)

> Also: is this broken in master ? In next ? What is this fixing ? (Note:
> I know all of this because we discussed it on IRC, but it should be in
> the commit log).

Got. it. I'll send v2 as soon as big merge is completed.

Regards,
Yegor
diff mbox series

Patch

diff --git a/package/uboot-tools/0005-Specify-dtc-binary-statically.patch b/package/uboot-tools/0005-Specify-dtc-binary-statically.patch
new file mode 100644
index 0000000000..75e81ccc85
--- /dev/null
+++ b/package/uboot-tools/0005-Specify-dtc-binary-statically.patch
@@ -0,0 +1,31 @@ 
+From ef8afdfd4701c3a7f416efcc173dfb7907ab355b Mon Sep 17 00:00:00 2001
+From: Yegor Yefremov <yegorslists@googlemail.com>
+Date: Fri, 1 Dec 2017 07:53:40 +0100
+Subject: [PATCH 5/5] Specify dtc binary statically
+
+In Buildroot we don't perform Kconfig configuration for
+u-boot-tools, hence CONFIG_MKIMAGE_DTC_PATH is empty.
+
+Specify MKIMAGE_DTC as "dtc" to restore previous behavior.
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+---
+ tools/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/Makefile b/tools/Makefile
+index 9c58a01..8f32db9 100644
+--- a/tools/Makefile
++++ b/tools/Makefile
+@@ -172,7 +172,7 @@ HOSTCFLAGS_rsa-sign.o += -Wno-deprecated-declarations
+ endif
+ endif
+ 
+-HOSTCFLAGS_fit_image.o += -DMKIMAGE_DTC=\"$(CONFIG_MKIMAGE_DTC_PATH)\"
++HOSTCFLAGS_fit_image.o += -DMKIMAGE_DTC=\"dtc\"
+ 
+ HOSTLOADLIBES_dumpimage := $(HOSTLOADLIBES_mkimage)
+ HOSTLOADLIBES_fit_info := $(HOSTLOADLIBES_mkimage)
+-- 
+2.1.4
+