pci: dwc: pci-dra7xx: Make shutdown handler static

Message ID 20171201050652.13998-1-vigneshr@ti.com
State Accepted
Headers show
Series
  • pci: dwc: pci-dra7xx: Make shutdown handler static
Related show

Commit Message

Vignesh R Dec. 1, 2017, 5:06 a.m.
Declare dra7xx_pcie_shutdown() as a static function as its not used
elsewhere.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/pci/dwc/pci-dra7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

J, KEERTHY Dec. 1, 2017, 5:13 a.m. | #1
On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.

Seems like the below version that had static version was not taken:

https://patchwork.kernel.org/patch/10052579/

So for this patch:

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/pci/dwc/pci-dra7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>  }
>  #endif
>  
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>
Lorenzo Pieralisi Dec. 1, 2017, 4:53 p.m. | #2
On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> 
> 
> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > elsewhere.
> 
> Seems like the below version that had static version was not taken:
> 
> https://patchwork.kernel.org/patch/10052579/

It looks like I can drop the patch above then - let me know if
that's ok.

Thanks,
Lorenzo

> So for this patch:
> 
> Reviewed-by: Keerthy <j-keerthy@ti.com>
> 
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> >  drivers/pci/dwc/pci-dra7xx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > index 59e8de34cec6..b9db442af793 100644
> > --- a/drivers/pci/dwc/pci-dra7xx.c
> > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> >  }
> >  #endif
> >  
> > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> >  {
> >  	struct device *dev = &pdev->dev;
> >  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> >
Lorenzo Pieralisi Dec. 20, 2017, 10:29 a.m. | #3
On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> > 
> > 
> > On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > > elsewhere.
> > 
> > Seems like the below version that had static version was not taken:
> > 
> > https://patchwork.kernel.org/patch/10052579/
> 
> It looks like I can drop the patch above then - let me know if
> that's ok.

I would appreciate some feedback; I assume that dropping the patch above
and applying the patch in $SUBJECT is what you expect, if there is a
problem with that please manifest yourselves.

Lorenzo

> Thanks,
> Lorenzo
> 
> > So for this patch:
> > 
> > Reviewed-by: Keerthy <j-keerthy@ti.com>
> > 
> > > 
> > > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > > ---
> > >  drivers/pci/dwc/pci-dra7xx.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > > index 59e8de34cec6..b9db442af793 100644
> > > --- a/drivers/pci/dwc/pci-dra7xx.c
> > > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> > >  }
> > >  #endif
> > >  
> > > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > >  {
> > >  	struct device *dev = &pdev->dev;
> > >  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> > >
Lorenzo Pieralisi Dec. 20, 2017, 11:11 a.m. | #4
On Fri, Dec 01, 2017 at 10:36:52AM +0530, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.
> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/pci/dwc/pci-dra7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc for v4.16.

Thanks,
Lorenzo

> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>  }
>  #endif
>  
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> -- 
> 2.15.0
>
J, KEERTHY Dec. 20, 2017, 11:59 a.m. | #5
On Wednesday 20 December 2017 03:59 PM, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
>> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
>>>
>>>
>>> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
>>>> Declare dra7xx_pcie_shutdown() as a static function as its not used
>>>> elsewhere.
>>>
>>> Seems like the below version that had static version was not taken:
>>>
>>> https://patchwork.kernel.org/patch/10052579/
>>
>> It looks like I can drop the patch above then - let me know if
>> that's ok.
> 
> I would appreciate some feedback; I assume that dropping the patch above
> and applying the patch in $SUBJECT is what you expect, if there is a
> problem with that please manifest yourselves.

Applying this patch is fine. Thanks.

> 
> Lorenzo
> 
>> Thanks,
>> Lorenzo
>>
>>> So for this patch:
>>>
>>> Reviewed-by: Keerthy <j-keerthy@ti.com>
>>>
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>>  drivers/pci/dwc/pci-dra7xx.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>>> index 59e8de34cec6..b9db442af793 100644
>>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>>> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>>>>  }
>>>>  #endif
>>>>  
>>>> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>>  {
>>>>  	struct device *dev = &pdev->dev;
>>>>  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>>>>

Patch

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 59e8de34cec6..b9db442af793 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -815,7 +815,7 @@  static int dra7xx_pcie_resume_noirq(struct device *dev)
 }
 #endif
 
-void dra7xx_pcie_shutdown(struct platform_device *pdev)
+static void dra7xx_pcie_shutdown(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);