pci: dwc: pci-dra7xx: Make shutdown handler static

Message ID 20171201050652.13998-1-vigneshr@ti.com
State New
Headers show
Series
  • pci: dwc: pci-dra7xx: Make shutdown handler static
Related show

Commit Message

Vignesh R Dec. 1, 2017, 5:06 a.m.
Declare dra7xx_pcie_shutdown() as a static function as its not used
elsewhere.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/pci/dwc/pci-dra7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Keerthy Dec. 1, 2017, 5:13 a.m. | #1
On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.

Seems like the below version that had static version was not taken:

https://patchwork.kernel.org/patch/10052579/

So for this patch:

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  drivers/pci/dwc/pci-dra7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>  }
>  #endif
>  
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>
Lorenzo Pieralisi Dec. 1, 2017, 4:53 p.m. | #2
On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> 
> 
> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > elsewhere.
> 
> Seems like the below version that had static version was not taken:
> 
> https://patchwork.kernel.org/patch/10052579/

It looks like I can drop the patch above then - let me know if
that's ok.

Thanks,
Lorenzo

> So for this patch:
> 
> Reviewed-by: Keerthy <j-keerthy@ti.com>
> 
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> >  drivers/pci/dwc/pci-dra7xx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > index 59e8de34cec6..b9db442af793 100644
> > --- a/drivers/pci/dwc/pci-dra7xx.c
> > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> >  }
> >  #endif
> >  
> > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> >  {
> >  	struct device *dev = &pdev->dev;
> >  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> >

Patch

diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 59e8de34cec6..b9db442af793 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -815,7 +815,7 @@  static int dra7xx_pcie_resume_noirq(struct device *dev)
 }
 #endif
 
-void dra7xx_pcie_shutdown(struct platform_device *pdev)
+static void dra7xx_pcie_shutdown(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);