Patchwork Add TAGS and *~ to .gitignore

login
register
mail settings
Submitter David Gibson
Date Feb. 24, 2011, 5:34 a.m.
Message ID <20110224053459.GG26300@yookeroo>
Download mbox | patch
Permalink /patch/84320/
State New
Headers show

Comments

David Gibson - Feb. 24, 2011, 5:34 a.m.
Add the etags output generated by "make TAGS" and editor backup files
to .gitignore.

This patch has previously appeared in my series of patches to add
pSeries emulation support.  However, it obviously has no real
connection to that, and can be applied seperately.

Please apply.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 .gitignore |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Markus Armbruster - Feb. 24, 2011, 7:05 a.m.
David Gibson <david@gibson.dropbear.id.au> writes:

> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.

Yes, please.
Juan Quintela - Feb. 24, 2011, 9:19 a.m.
David Gibson <david@gibson.dropbear.id.au> wrote:
> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Reviewed-by: Juan Quintela <quintela@redhat.com>

O:-)

> ---
>  .gitignore |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 26703e1..1d79680 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,5 @@ pc-bios/optionrom/multiboot.raw
>  .stgit-*
>  cscope.*
>  tags
> +TAGS
> +*~
> -- 
> 1.7.1
Anthony Liguori - Feb. 24, 2011, 6:10 p.m.
On 02/23/2011 11:34 PM, David Gibson wrote:
> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.
>
> Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   .gitignore |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 26703e1..1d79680 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,5 @@ pc-bios/optionrom/multiboot.raw
>   .stgit-*
>   cscope.*
>   tags
> +TAGS
> +*~
>
Stefan Weil - Feb. 24, 2011, 8:21 p.m.
.gitignore contains two categories of entries:

(1) files and directories which are created during configure / make

(2) files which might be created by users, editors and other tools

The 1st category of files is needed by any developer who runs make
in the source tree. There was once a suggestion to remove support
for in-tree builds. Out-of-tree builds would not need any entry in
.gitignore. So maintenance could be made easier, although I
don't recommend this.

The 2nd category is virtually endless because there are so many
different editors, IDEs, debuggers and other tools which create
different files. The entries here are nothing which is typical
of qemu. These entries are typical for the user: Do I use ctags?
Does my editor write *.bak or *~ files? Do I want a .gdbinit? ...

Therefore I think that all entries of the 2nd category should be
configured by the user in his/her personal git ignore list
(see git config setting core.excludesfile).

Regards,
Stefan Weil

Patch

diff --git a/.gitignore b/.gitignore
index 26703e1..1d79680 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,3 +63,5 @@  pc-bios/optionrom/multiboot.raw
 .stgit-*
 cscope.*
 tags
+TAGS
+*~