Message ID | 1511935854-13005-1-git-send-email-jay.shah1@rockwellcollins.com |
---|---|
State | Accepted |
Delegated to: | Pablo Neira |
Headers | show |
Series | [1/1] iptables: patch to correct linker flag sequence | expand |
On Wed, Nov 29, 2017 at 12:10:54AM -0600, Jay Shah wrote: > From: Yogesh Prasad <yogesh.prasad@rockwellcollins.com> > > Description > This patch will correct the sequence of -pie and -shared options. > When used together, -pie should be provided to the linker before > -shared. If -pie is provided after -shared, the linker throws an > error shown below as example. > > ------------------------------------------------------------------------- > /host/lib/gcc/powerpc-buildroot-linux-gnu/6.4.0/../../../.. > /powerpc-buildroot-linux-gnu/bin/ld: BFD (GNU Binutils) 2.28.1 > assertion fail elf32-ppc.c:8923 > collect2: error: ld returned 1 exit status > + ./libxt_SYNPROXY.man > make[4]: *** [libxt_TCPOPTSTRIP.so] Error 1 > + ./libip6t_mh.man > /host/powerpc-buildroot-linux-gnu/sysroot/usr/lib/Scrt1.o:(.data+0x4): > undefined reference to `main' > /host/lib/gcc/powerpc-buildroot-linux-gnu + ./libxt_TCPMSS.man > /6.4.0/../../../../powerpc-buildroot-linux-gnu/bin/ld: > BFD (GNU Binutils) 2.28.1 assertion fail elf32-ppc.c:8923 > collect2: error: ld returned 1 exit status > ------------------------------------------------------------------------- Applied. Out of curiosity: Does it say anywhere that the options need to be in a specific order, eg. documentation. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in index b7a8a83..bee666e 100644 --- a/extensions/GNUmakefile.in +++ b/extensions/GNUmakefile.in @@ -101,7 +101,7 @@ init%.o: init%.c # Shared libraries # lib%.so: lib%.oo - ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $< -L../libxtables/.libs -lxtables ${$*_LIBADD}; + ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} ${LDFLAGS} -shared -o $@ $< -L../libxtables/.libs -lxtables ${$*_LIBADD}; lib%.oo: ${srcdir}/lib%.c ${AM_VERBOSE_CC} ${CC} ${AM_CPPFLAGS} ${AM_DEPFLAGS} ${AM_CFLAGS} -D_INIT=lib$*_init -DPIC -fPIC ${CFLAGS} -o $@ -c $<;