| Message ID | 20171128115930.10887-1-gael.portay@savoirfairelinux.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/1] package/qt5: simplify and cleanup _SITE variables | expand |
With the missing changelog. On Tue, Nov 28, 2017 at 06:59:30AM -0500, Gaël PORTAY wrote: > The variable QT5_SNAPSHOTS_SITE was introduced in commit 9d5ac9698 to > fetch sources of obsolete modules. It was used to download qt5webkit > tarballs. > > The variable is not referenced anymore since the qt5webkit tarballs are > downloaded from the Qt community release site. > > Since the introduction of qt-5.9 in aa1c40ba3, the QT5_SITE variable > was duplicates for no good reason. > > Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- Changes since v1: * reword asked by Yann to complete the commit message. * add the acked-by of Yann.
Hello, On Tue, 28 Nov 2017 06:59:30 -0500, Gaël PORTAY wrote: > The variable QT5_SNAPSHOTS_SITE was introduced in commit 9d5ac9698 to > fetch sources of obsolete modules. It was used to download qt5webkit > tarballs. > > The variable is not referenced anymore since the qt5webkit tarballs are > downloaded from the Qt community release site. > > Since the introduction of qt-5.9 in aa1c40ba3, the QT5_SITE variable > was duplicates for no good reason. > > Signed-off-by: Gaël PORTAY <gael.portay@savoirfairelinux.com> > Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/qt5/qt5.mk | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied to next, thanks. Thomas
diff --git a/package/qt5/qt5.mk b/package/qt5/qt5.mk index 0e49c6b58b..5d63433666 100644 --- a/package/qt5/qt5.mk +++ b/package/qt5/qt5.mk @@ -7,13 +7,11 @@ ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) QT5_VERSION_MAJOR = 5.9 QT5_VERSION = $(QT5_VERSION_MAJOR).2 -QT5_SITE = http://download.qt.io/official_releases/qt/$(QT5_VERSION_MAJOR)/$(QT5_VERSION)/submodules else QT5_VERSION_MAJOR = 5.6 QT5_VERSION = $(QT5_VERSION_MAJOR).3 -QT5_SITE = http://download.qt.io/official_releases/qt/$(QT5_VERSION_MAJOR)/$(QT5_VERSION)/submodules -QT5_SNAPSHOTS_SITE = http://download.qt.io/snapshots/qt/$(QT5_VERSION_MAJOR)/$(QT5_VERSION)/latest_src/submodules endif +QT5_SITE = http://download.qt.io/official_releases/qt/$(QT5_VERSION_MAJOR)/$(QT5_VERSION)/submodules include $(sort $(wildcard package/qt5/*/*.mk))