[linux] ARM: dts: aspeed-g4: add serial gpio driver entry

Message ID 20171127200738.188390-1-venture@google.com
State Accepted, archived
Headers show
Series
  • [linux] ARM: dts: aspeed-g4: add serial gpio driver entry
Related show

Commit Message

Patrick Venture Nov. 27, 2017, 8:07 p.m.
Adds the serial gpio driver entry for the aspeed
ast2400.

Signed-off-by: Patrick Venture <venture@google.com>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Patrick Venture Nov. 27, 2017, 8:10 p.m. | #1
There isn't yet a binding for this, but if it's acceptable. I'm going
to submit a gpio driver strictly for the serial gpio once I can test
on an ast2500.  I'm presently finalizing the ast2400 version of the
driver.

- Patrick

On Mon, Nov 27, 2017 at 12:07 PM, Patrick Venture <venture@google.com> wrote:
> Adds the serial gpio driver entry for the aspeed
> ast2400.
>
> Signed-off-by: Patrick Venture <venture@google.com>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 424d843ec1da..b82ebefcb025 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -238,6 +238,15 @@
>                                 clocks = <&clk_hpll>;
>                         };
>
> +                       sgpio: gpio@0x1e780200 {
> +                               #gpio-cells = <2>;
> +                               gpio-controller;
> +                               compatible = "aspeed,ast2400-sgpio";
> +                               reg = <0x1e780200 0x100>;
> +                               interrupts = <40>;
> +                               interrupt-controller;
> +                       };
> +
>                         timer: timer@1e782000 {
>                                 compatible = "aspeed,ast2400-timer";
>                                 reg = <0x1e782000 0x90>;
> --
> 2.15.0.417.g466bffb3ac-goog
>
Joel Stanley Dec. 8, 2017, 6:26 a.m. | #2
On Tue, Nov 28, 2017 at 6:40 AM, Patrick Venture <venture@google.com> wrote:
> There isn't yet a binding for this, but if it's acceptable. I'm going
> to submit a gpio driver strictly for the serial gpio once I can test
> on an ast2500.  I'm presently finalizing the ast2400 version of the
> driver.

We can stage the device tree change in the openbmc tree if it helps
your development.

Applied to dev-4.10.

Cheers,

Joel

>
> - Patrick
>
> On Mon, Nov 27, 2017 at 12:07 PM, Patrick Venture <venture@google.com> wrote:
>> Adds the serial gpio driver entry for the aspeed
>> ast2400.
>>
>> Signed-off-by: Patrick Venture <venture@google.com>
>> ---
>>  arch/arm/boot/dts/aspeed-g4.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
>> index 424d843ec1da..b82ebefcb025 100644
>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>> @@ -238,6 +238,15 @@
>>                                 clocks = <&clk_hpll>;
>>                         };
>>
>> +                       sgpio: gpio@0x1e780200 {
>> +                               #gpio-cells = <2>;
>> +                               gpio-controller;
>> +                               compatible = "aspeed,ast2400-sgpio";
>> +                               reg = <0x1e780200 0x100>;
>> +                               interrupts = <40>;
>> +                               interrupt-controller;
>> +                       };
>> +
>>                         timer: timer@1e782000 {
>>                                 compatible = "aspeed,ast2400-timer";
>>                                 reg = <0x1e782000 0x90>;
>> --
>> 2.15.0.417.g466bffb3ac-goog
>>

Patch

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index 424d843ec1da..b82ebefcb025 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -238,6 +238,15 @@ 
 				clocks = <&clk_hpll>;
 			};
 
+			sgpio: gpio@0x1e780200 {
+				#gpio-cells = <2>;
+				gpio-controller;
+				compatible = "aspeed,ast2400-sgpio";
+				reg = <0x1e780200 0x100>;
+				interrupts = <40>;
+				interrupt-controller;
+			};
+
 			timer: timer@1e782000 {
 				compatible = "aspeed,ast2400-timer";
 				reg = <0x1e782000 0x90>;