From patchwork Mon Nov 27 07:06:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Alan 1. (NSB - CN/Hangzhou)" X-Patchwork-Id: 841495 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nokia.onmicrosoft.com header.i=@nokia.onmicrosoft.com header.b="XUmaC4bi"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yldDd1D4Fz9ryk for ; Mon, 27 Nov 2017 18:08:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751264AbdK0HIP (ORCPT ); Mon, 27 Nov 2017 02:08:15 -0500 Received: from mail-eopbgr50095.outbound.protection.outlook.com ([40.107.5.95]:55744 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751231AbdK0HIO (ORCPT ); Mon, 27 Nov 2017 02:08:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector2-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a+B1MZwW9hvNyx17ErcGLh0QejL0le3+7E8hGoOsDa0=; b=XUmaC4biysPc2QzNsmEWrwW1utESKKLkvyMekYmN8fwCgBliViK7H9gcUhWxeo/fQj6/rYblC3QOEuU65Bv/iq3cHICE/k7MWW695IgIoMZ9QDIXXVsMYZq7VFG7Cle6D6xp7IKvYs/RjEKx/fI0xWvRm76koxyjr/yMWWR2o4k= Received: from HE1PR07CA0016.eurprd07.prod.outlook.com (2603:10a6:7:67::26) by DB3PR07MB0764.eurprd07.prod.outlook.com (2a01:111:e400:9443::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.3; Mon, 27 Nov 2017 07:08:10 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::202) by HE1PR07CA0016.outlook.office365.com (2603:10a6:7:67::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.3 via Frontend Transport; Mon, 27 Nov 2017 07:08:10 +0000 Authentication-Results: spf=pass (sender IP is 131.228.2.241) smtp.mailfrom=nokia-sbell.com; the-dreams.de; dkim=none (message not signed) header.d=none;the-dreams.de; dmarc=pass action=none header.from=nokia-sbell.com; Received-SPF: Pass (protection.outlook.com: domain of nokia-sbell.com designates 131.228.2.241 as permitted sender) receiver=protection.outlook.com; client-ip=131.228.2.241; helo=mailrelay.int.nokia.com; Received: from mailrelay.int.nokia.com (131.228.2.241) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.239.4 via Frontend Transport; Mon, 27 Nov 2017 07:08:09 +0000 Received: from fihe3nok0735.emea.nsn-net.net (localhost [127.0.0.1]) by fihe3nok0735.emea.nsn-net.net (8.14.9/8.14.5) with ESMTP id vAR77SIA008530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Nov 2017 09:07:28 +0200 Received: from hzling45.china.nsn-net.net (hzling45.china.nsn-net.net [10.159.218.88]) by fihe3nok0735.emea.nsn-net.net (8.14.9/8.14.5) with ESMTP id vAR77Rl8008490; Mon, 27 Nov 2017 09:07:27 +0200 X-HPESVCS-Source-Ip: 10.159.218.88 Received: by hzling45.china.nsn-net.net (Postfix, from userid 62069633) id 31D8E65A2B; Mon, 27 Nov 2017 15:07:25 +0800 (CST) From: Lixin Wang To: Wolfram Sang CC: , , Lixin Wang Subject: [PATCH] i2c: core: decrease reference count of device node in i2c_unregister_device Date: Mon, 27 Nov 2017 15:06:55 +0800 Message-ID: <1511766415-3732-1-git-send-email-alan.1.wang@nokia-sbell.com> X-Mailer: git-send-email 2.6.2 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:131.228.2.241; IPV:CAL; SCL:-1; CTRY:FI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(346002)(376002)(39860400002)(2980300002)(438002)(199003)(189002)(2906002)(90966002)(33646002)(15760500003)(107886003)(106466001)(5660300001)(6666003)(6916009)(50986999)(51416003)(53936002)(68736007)(6266002)(22756006)(4326008)(45336002)(478600001)(26826003)(50226002)(46386002)(106002)(16586007)(189998001)(54906003)(97736004)(42186006)(36756003)(8676002)(316002)(305945005)(48376002)(86362001)(50466002)(52956003)(356003)(81166006)(8936002)(103686004)(47776003)(81156014); DIR:OUT; SFP:1102; SCL:1; SRVR:DB3PR07MB0764; H:mailrelay.int.nokia.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; A:0; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; VE1EUR03FT057; 1:d9lyHjDJLTJmjSyryYNrvXirCaU2cbtT1yVvdbKc5GbAegXOWsrZWeKCWBJG9Hn1HsBdtNYaTDlE4gsw0e+lWMAgFP/Sb7+eyu8wQ0n9RdssGq3xBuy57wD7VIU1+rjP MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d311a41-6b2a-4721-38de-08d535659dd5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4608076)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:DB3PR07MB0764; X-Microsoft-Exchange-Diagnostics: 1; DB3PR07MB0764; 3:Eky+Kufe0FmXXMffvsz3vTIZLtVt5tX+r93YM+90A/eIJ1so01kkIV7ddoXxZKDHAoYwWZ6wIvKpNpf41bGq73aOpElZL8l3UpadowSOv5kXyxLqfHtSC/ponRrMx0FDA0hEKTf+Ewpn3u8HGs4rIQ/NQTiSYDlqhiLNXZgnlWZFShsENQutVBhtTQ5t4nACBISL3Gg6bBRmEB0SYhz4jRJy4tVACTcfhbGKQX7x0ahbq0sxIvF/mR06VWIVn9AEyCbeJWK1r53a9Tn5XUqIH74OrsLmFQug7ROQJFDz/4qSwNxl0qibt8rOCuXbFMv+xe64CdUwvFrv6A+qIr+LX9hLMydjXyES3Ro6+PHFBAM=; 25:pm5C0jTouM7VQ6igO921T/h/PzCEq7Ypyad9up6/s2XRMjSSwfyuunroZNQ2Jargm9wK0d8Rk/oGnG+I9KhLG+Ydp4subX4ZXmGcZPxP+VWroA3fMbqVixpWwteJa8qZfKZDG4HrNT6ubuaXtEBuKiRGgFAbL/1Z64kXEfWuG275sGpgXsvny5oV0sPE+lL3IwbjQchCXfoPWRZSn7+5Fm0O2v0X+Wkw/3ar8lgPFxXIozTTbE3bfgcpDAIyrd/4v+GPU1GrES7W8DizpeHKuf7ppwzb2B1TctVWl8djR80prxbxXTS2Pg4Eczn8QPAiQeWA3+VmVVRpsh/JE+vd8fRKArIEFWjySBfpP4bRZpA= X-MS-TrafficTypeDiagnostic: DB3PR07MB0764: X-Microsoft-Exchange-Diagnostics: 1; DB3PR07MB0764; 31:wA1xNJNoODCQwL++aenVIgYi7MQPp3a1JBX+EYCVhix6OqmJGq7mbUm1l/IvjAgGUXaaNegpM5oUD24mxN9fwT/V8mJosWfiYkc3n+KL1dByaW2inO6BNuuKW+biK7zsApwV8Iba4XrftzLskfkuQkhUEEv41xNPIaevr1XXErJiAGhSk0xUHLEWynKZNC5kRaQcDK24X0DTc9n2CMAOtyPwEklD9dDASdhKrwYL4eQ=; 20:LYM1uxgsRjrr2qN/ub5vMyNtZytoBNDSf6cPUeJPfss51q/5IKEmbDYuZox5i2QvJSlWnZsWwH7jpUTkGuyBhk8gLHKG7ppMGhZxIJWv+91ViZs21uAl7lMUpZefM97yN/1OoJkjsIjrifXwxtKxbNqpn6otyJUZl8g1PWRWY5123k+EeDmXyz3ZJkFe5qbz+nIV5I3YmOrixdYoBfIhmV6ExRtTEeNsq0iE8kWTOnV2StTzGarJMB8Md6p6AeW8IoXxTodACodAOktoRpNHG5MBPg7JF2/b5B6Tj1+/qB37zZnA75+U9QPupPM3psCAw44JplbGQdd4A7WF2yzxLz7e09rWfrHriTeEgdh2HP7SeQA6EiMF9B0s3YpDEw27VbzoksNJQZa2pgrO+6ohQ+dZ1wvIf6sK49206kYjImCgqU9eLgHJM8+fXJHd8s8snrljHvQFiyO0fkRCeJx3JvuacCZnlBA3Tu3TX6K64zk25HBFhuo2hf2bB1s7dxUnrg2Z3KuBW+TIuKntTAZBnmKCOpY5UC/U4dO/ALXWCauA8rt5M0o9zK0Iq8cDIXUmx8wLS5D93RRrLoZGNab1zymVyHhZmcaABdKdgrvFyBc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93004095)(10201501046)(3231022)(6055026)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011); SRVR:DB3PR07MB0764; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DB3PR07MB0764; X-Microsoft-Exchange-Diagnostics: 1; DB3PR07MB0764; 4:AlE/vtoLznrXtlcv3H9wRV9mOFOYy3qrsS/vlqqq6Yuxe2XoTrTqHEtxArN4z06iGOErhm50ptB0bNgT5rS+kJ9V7Am+DrwNGX8vFb+QVGsVVGsavQvjnzaLJ2wnYAHbKXV819iY6HVIGO2LMencIOx9hD1qnv076D8Zr3PgMutnX2TunTKN6KM1bwszo43moAijQ8uLYd7p9v4QOBx2//uye1f6q0XmVOsHVytJSHuYHN3q/jvpn1coY288dQOQxaFzQ4ehvEncjKhPQ8u/kg== X-Forefront-PRVS: 0504F29D72 X-Microsoft-Exchange-Diagnostics: 1; DB3PR07MB0764; 23:dffoVpFLBxXcAOI/D8xmWoJCbfXMBaSJYRj4d06SwZQgmEx0e5NL0VVUZACK1O2sPYp/KyZb33bHcclke9hZ3paEy+z90xSDe/8AE199gu0mHS2k4a16a/+ajspZZ7G7O6m6AKmwXDPMBdqMZvaKV6PYV89tQhm7KttMezA48JXfrH/YJgBHZf1RNP/MwJaEfhIi6e3eEkPedgN8osF9mmO+5na9z1M2J7LVEhX7TkwY01dmsmah5egiKwu755Ujjx4sm/c9+MSEt/g1zSmxI0Y3rVSsWy5Muw6J90A2Vpg5yWMmG5ngSDR9duQYGRhXCKy1cWtyQypK+DeMoPzE1WMT440XFkZWJPQnarVvAhusnOKA3t5GaiT3xZfMR4cPeplFKCob6lzDQXt7iLPCwof0M6HlpCbW9PDDVJY5aS/zulIXaoh5oY1nshfaNyLtdwR6sgp38Y9KkPCLjtIbWBZldFdStJirt9oniStW10QscOJFCf5LG9Hb74uYlildQKZvLktQqNBUidCB+RkFxsP7Xf8JU+k/AUEqjXFVXJ/rblozDIFoei0xKQrk3u4sn1gKpYLwVf2614yBfSzMl5YPkBNrAjXX/puSruR36Fg/QQKVCSoLk575wsFE9eQNGsrih4WTccGI7obSIuI4DzwzocVGxQ+MGKQ7Ykbytbrt0RK9HKpAKg0kTjdN/uGtyF9fpuqt5vdwVZWPJodJPby9n8UA0nNoF9GLR3SOSjApqvEDaRDqjHi5FS6cZSXgI0po1Z9rlkQjwNm13ICHIvb9595iCNzdSMnx7vefHq0Caga+/kjNyD0Hs41YD2BAAVv1z/A5cCtOvMsGEkq4DhFl/99kbOShMTgnW/4bq8VlkHapAw1XC1mr6mPliRKgy0wrrNlrFeyKy6FylkqBxcQ0irgqIV58iGVZ6kAELyultgFfs4N2RSxBVAHmxMdv1KOuV3ytgByY/JWd6MyJsF18sgCTX1k/i44H+PdsGE55Mr7ZEbppKGfDxp+zgksVIGunI+jMW4HVHopsD2qOvUT5L6BXvmT99eKF4uCxayI8F5AldX7sQ7/ip0KUr8yBLk9LXUURI3lsiqG132JC8q+VbHTcyMEA6bneL1h7tOWAwfEdClkDMgVarb45L69J X-Microsoft-Antispam-Message-Info: IwUkCTWnyxr8jz3TZ/qoQCqBsYXDL2TvRxXSKVfGG002MvzKD2o9/0lXGEa775PkAT9dCm3828fRan2214PYVQ== X-Microsoft-Exchange-Diagnostics: 1; DB3PR07MB0764; 6:Eq+bu/9hslbftXJYxyzpuQ6bkIsp9CemiIRzDOpLazyC/95mXGyqWQ2mGII6Odax2qUe012TkQKQ+ReCAboI96XE6TAQ8ONCQZ+WbBVxuhH1hWa7FbfsIJka3klTMD/jHib6VuuF4LdnbAZZ3btpd201pLbNqdrNBRHxDdTz6biY7pWd+oyBNHzEASDRVB4LjSiuytlRYzQovsYTZ7BljbscXqRuOYuVvLOem3XPKHg4CCqOqHLrlPY9y73yYjaJ6iPDuxYpvadriCy6G6tpoj1aN+Dd27dFBxBjORojKICekKctSgp2TPZOhhARN53DZ4fW+H2DmHYGV6uHNA5H28nLDxG2hzLbzIlobpOFdYg=; 5:c/FMBQj0mu/M0gWk2cKdAcFemHlGO1AxKh/FRVR/khmLzbzGOTUkNssg9p1wxPUtqcmQa0+8S5CclVlVDt0AnQlPWv6XfPcLBHH9pHHQQCq09x1U2kkKi7A76KDNMnRhFeYx7CUTrAsKJbvKaw3w4PNqJze5ruu7FH+9j/uvhqc=; 24:2k97DPq05+bEcFV+VOqrxLaO5SHm73oV6wRTM5cmFGyq6f/H/LzV6bCRQNct+dQyURabeqV2ICUMj4kyM/GbH3xcUpuQ+MqWUy8xAyydYgI=; 7:U92m4rxWnkOwwdDGQ7FHqtk+nlLQyHZtrIxU2nDmVDBNaSIUmk4xrCgYA+uuPvE72cXFUL7eGw0WHd8NECXcsfZv+Qlb8ng4H01oO73V2FPmKbBawIwW6QIJXlJ6BB9MClKqHd5foaZX0ZRFZkfVChsIFCY1YgG2IcItlM9Jp4NW1aWwJRcB0dLV3MYbhlBdGBDXj+xqKI/jxjZG+C4fL80/+imIbvXIpmnBO34vtrdjiUg3zhNE71WsQf7GI3wO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2017 07:08:09.6883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d311a41-6b2a-4721-38de-08d535659dd5 X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0; Ip=[131.228.2.241]; Helo=[mailrelay.int.nokia.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR07MB0764 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Reference count of device node was increased in of_i2c_register_device, but without decreasing it in i2c_unregister_device. Then the dynamically added device node will never be released. Fix this by adding the of_node_put. Signed-off-by: Lixin Wang --- drivers/i2c/i2c-core-base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 56e4658..b76adf9 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -808,8 +808,10 @@ EXPORT_SYMBOL_GPL(i2c_new_device); */ void i2c_unregister_device(struct i2c_client *client) { - if (client->dev.of_node) + if (client->dev.of_node) { of_node_clear_flag(client->dev.of_node, OF_POPULATED); + of_node_put(client->dev.of_node); + } if (ACPI_COMPANION(&client->dev)) acpi_device_clear_enumerated(ACPI_COMPANION(&client->dev)); device_unregister(&client->dev);