Patchwork [1/2] rtc: rtc-mc13xxx: fix unterminated platform_device_id table

login
register
mail settings
Submitter Axel Lin
Date Feb. 23, 2011, 9:27 a.m.
Message ID <1298453244.25444.1.camel@mola>
Download mbox | patch
Permalink /patch/84112/
State New
Headers show

Comments

Axel Lin - Feb. 23, 2011, 9:27 a.m.
The platform_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/rtc/rtc-mc13xxx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Uwe Kleine-König - Feb. 23, 2011, 9:57 a.m.
On Wed, Feb 23, 2011 at 05:27:24PM +0800, Axel Lin wrote:
> The platform_device_id table is supposed to be zero-terminated.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/rtc/rtc-mc13xxx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c
> index 5314b15..6e6de98 100644
> --- a/drivers/rtc/rtc-mc13xxx.c
> +++ b/drivers/rtc/rtc-mc13xxx.c
> @@ -408,6 +408,7 @@ const struct platform_device_id mc13xxx_rtc_idtable[] = {
>  	}, {
>  		.name = "mc13892-rtc",
>  	},
> +	{ }
>  };
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
for both patches.  I wonder how that worked before, just luck I assume.

Thanks
Uwe

Patch

diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c
index 5314b15..6e6de98 100644
--- a/drivers/rtc/rtc-mc13xxx.c
+++ b/drivers/rtc/rtc-mc13xxx.c
@@ -408,6 +408,7 @@  const struct platform_device_id mc13xxx_rtc_idtable[] = {
 	}, {
 		.name = "mc13892-rtc",
 	},
+	{ }
 };
 
 static struct platform_driver mc13xxx_rtc_driver = {