[3/5] KVM: PPC: Book3S HV: Remove useless statement

Message ID 1511427665-21660-4-git-send-email-paulus@ozlabs.org
State New
Headers show
Series
  • KVM: PPC: Book3S: Miscellaneous minor fixes
Related show

Commit Message

Paul Mackerras Nov. 23, 2017, 9:01 a.m.
This removes a statement that has no effect.  It should have been
removed in commit 898b25b202f3 ("KVM: PPC: Book3S HV: Simplify dynamic
micro-threading code", 2017-06-22) along with the loop over the
piggy-backed virtual cores.

This issue was reported by Coverity.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
---
 arch/powerpc/kvm/book3s_hv.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Darren Kenny Nov. 23, 2017, 10:15 a.m. | #1
On Thu, Nov 23, 2017 at 08:01:03PM +1100, Paul Mackerras wrote:
>This removes a statement that has no effect.  It should have been
>removed in commit 898b25b202f3 ("KVM: PPC: Book3S HV: Simplify dynamic
>micro-threading code", 2017-06-22) along with the loop over the
>piggy-backed virtual cores.
>
>This issue was reported by Coverity.
>

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

>Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
>---
> arch/powerpc/kvm/book3s_hv.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
>index 2d46037..597498d 100644
>--- a/arch/powerpc/kvm/book3s_hv.c
>+++ b/arch/powerpc/kvm/book3s_hv.c
>@@ -2831,7 +2831,6 @@ static noinline void kvmppc_run_core(struct kvmppc_vcore *vc)
> 		 */
> 		if (!thr0_done)
> 			kvmppc_start_thread(NULL, pvc);
>-		thr += pvc->num_threads;
> 	}
>
> 	/*
>-- 
>2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 2d46037..597498d 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -2831,7 +2831,6 @@  static noinline void kvmppc_run_core(struct kvmppc_vcore *vc)
 		 */
 		if (!thr0_done)
 			kvmppc_start_thread(NULL, pvc);
-		thr += pvc->num_threads;
 	}
 
 	/*