[Artful/linux-oem,v2] ALSA: hda - fix headset mic problem for Dell machines with alc274

Message ID 1511408800-4200-2-git-send-email-hui.wang@canonical.com
State New
Headers show
Series
  • [Artful/linux-oem,v2] ALSA: hda - fix headset mic problem for Dell machines with alc274
Related show

Commit Message

Hui Wang Nov. 23, 2017, 3:46 a.m.
BugLink: http://bugs.launchpad.net/bugs/1731822

Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
the pin 0x1a is for Headphone Mic, he suggested to apply
ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
verified applying this FIXUP can fix this problem.

Cc: <stable@vger.kernel.org>
Cc: Kailang Yang <kailang@realtek.com>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Aaron Ma Nov. 23, 2017, 4:49 a.m. | #1
Clean cherry-pick with limited impacts,

Acked-by: Aaron Ma <aaron.ma@canonical.com>

On 11/23/2017 11:46 AM, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab8b154..64dc6f6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6523,6 +6523,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
>
Timo Aaltonen Nov. 26, 2017, 3:09 p.m. | #2
On 23.11.2017 05:46, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

this is already applied in Ubuntu-4.13.0-18.21, so a rebase is enough
for linux-oem -1009.
Colin King Nov. 30, 2017, 1:52 p.m. | #3
On 23/11/17 03:46, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab8b154..64dc6f6 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6523,6 +6523,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
> 

Clean cherry pick, limited SRU regression potential because this quirk
is for a specific device. Looks good to me.

Acked-by: Colin Ian King <colin.king@canonical.com>

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ab8b154..64dc6f6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6523,6 +6523,11 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x14, 0x90170110},
 		{0x1b, 0x90a70130},
 		{0x21, 0x03211020}),
+	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x12, 0xb7a60130},
+		{0x13, 0xb8a61140},
+		{0x16, 0x90170110},
+		{0x21, 0x04211020}),
 	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
 		{0x12, 0x90a60130},
 		{0x14, 0x90170110},