diff mbox series

Fix typo in variable name in gen-locale.sh [committed]

Message ID alpine.DEB.2.20.1711222343000.5929@digraph.polyomino.org.uk
State New
Headers show
Series Fix typo in variable name in gen-locale.sh [committed] | expand

Commit Message

Joseph Myers Nov. 22, 2017, 11:43 p.m. UTC 
2017-11-22  Joseph Myers  <joseph@codesourcery.com>

	* localedata/gen-locale.sh: Fix typo in variable name.

Comments

Jonathan Nieder Nov. 22, 2017, 11:46 p.m. UTC | #1 
Joseph Myers wrote:

> 2017-11-22  Joseph Myers  <joseph@codesourcery.com>
>
> 	* localedata/gen-locale.sh: Fix typo in variable name.

Good catch.  The fix is obviously correct.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

> diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
> index 757a0e9..39f1475 100644
> --- a/localedata/gen-locale.sh
> +++ b/localedata/gen-locale.sh
> @@ -69,7 +69,7 @@ fi
>  # warning. See localedata/Makefile $(INSTALL-SUPPORTED-LOCALES)
>  # for the same logic.
>  if [ "$charmap_real" = 'SHIFT_JIS' ] \
> -   || [ "$charmpa_real" = 'SHIFT_JISX0213' ]; then
> +   || [ "$charmap_real" = 'SHIFT_JISX0213' ]; then
>    flags="$flags --no-warnings=ascii"
>  fi
Carlos O'Donell Nov. 23, 2017, 1:21 a.m. UTC | #2 
On 11/22/2017 03:46 PM, Jonathan Nieder wrote:
> Joseph Myers wrote:
> 
>> 2017-11-22  Joseph Myers  <joseph@codesourcery.com>
>>
>> 	* localedata/gen-locale.sh: Fix typo in variable name.
> 
> Good catch.  The fix is obviously correct.
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Agreed, and it's my fault. I only tested SHIFT_JIS locales for the SUSE
builds. And given that we don't have any officially SUPPORTED ones, we
never see any issues here.

>> diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
>> index 757a0e9..39f1475 100644
>> --- a/localedata/gen-locale.sh
>> +++ b/localedata/gen-locale.sh
>> @@ -69,7 +69,7 @@ fi
>>  # warning. See localedata/Makefile $(INSTALL-SUPPORTED-LOCALES)
>>  # for the same logic.
>>  if [ "$charmap_real" = 'SHIFT_JIS' ] \
>> -   || [ "$charmpa_real" = 'SHIFT_JISX0213' ]; then
>> +   || [ "$charmap_real" = 'SHIFT_JISX0213' ]; then
>>    flags="$flags --no-warnings=ascii"
>>  fi
diff mbox series

Patch

diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
index 757a0e9..39f1475 100644
--- a/localedata/gen-locale.sh
+++ b/localedata/gen-locale.sh
@@ -69,7 +69,7 @@  fi
 # warning. See localedata/Makefile $(INSTALL-SUPPORTED-LOCALES)
 # for the same logic.
 if [ "$charmap_real" = 'SHIFT_JIS' ] \
-   || [ "$charmpa_real" = 'SHIFT_JISX0213' ]; then
+   || [ "$charmap_real" = 'SHIFT_JISX0213' ]; then
   flags="$flags --no-warnings=ascii"
 fi