diff mbox series

[U-Boot] boston: Set CONFIG_SYS_LOAD_ADDR to 0x88000000

Message ID 20171121203531.11899-1-paul.burton@mips.com
State Accepted
Commit fabcffe9305842970c51661a3506fff818eefe8a
Delegated to: Daniel Schwierzeck
Headers show
Series [U-Boot] boston: Set CONFIG_SYS_LOAD_ADDR to 0x88000000 | expand

Commit Message

Paul Burton Nov. 21, 2017, 8:35 p.m. UTC
Generally we load Linux kernels on Boston boards in the form of FIT
images containing a compressed kernel binary. Linux is linked at
0x80100000 and so we need to decompress the kernel binary to that
address, however this is our default load address which means that
unless explicitly avoided we hit a decompression error as the
uncompressed kernel binary overwrites its compressed version from the
FIT image.

Avoid this by adjusting CONFIG_SYS_LOAD_ADDR to 0x88000000 (or
0xffffffff88000000 for MIPS64 builds) which avoids the address overlap
between compressed & uncompressed kernel binaries.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: u-boot@lists.denx.de

---

 include/configs/boston.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Schwierzeck Nov. 21, 2017, 9:29 p.m. UTC | #1
On 21.11.2017 21:35, Paul Burton wrote:
> Generally we load Linux kernels on Boston boards in the form of FIT
> images containing a compressed kernel binary. Linux is linked at
> 0x80100000 and so we need to decompress the kernel binary to that
> address, however this is our default load address which means that
> unless explicitly avoided we hit a decompression error as the
> uncompressed kernel binary overwrites its compressed version from the
> FIT image.
> 
> Avoid this by adjusting CONFIG_SYS_LOAD_ADDR to 0x88000000 (or
> 0xffffffff88000000 for MIPS64 builds) which avoids the address overlap
> between compressed & uncompressed kernel binaries.
> 
> Signed-off-by: Paul Burton <paul.burton@mips.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: u-boot@lists.denx.de
> 
> ---
> 
>  include/configs/boston.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied to u-boot-mips, thanks.
diff mbox series

Patch

diff --git a/include/configs/boston.h b/include/configs/boston.h
index ee4e4a37ea..fdd5ef5632 100644
--- a/include/configs/boston.h
+++ b/include/configs/boston.h
@@ -34,7 +34,7 @@ 
 
 #define CONFIG_SYS_MONITOR_BASE		CONFIG_SYS_TEXT_BASE
 
-#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x100000)
+#define CONFIG_SYS_LOAD_ADDR		(CONFIG_SYS_SDRAM_BASE + 0x08000000)
 
 #define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x10000000)