diff mbox series

[U-Boot,2/5] mmc: dm: support "mmc-ddr-1_2v" and "mmc-hs200-1_2v" boolean properties

Message ID 1511277188-2923-3-git-send-email-jjhiblot@ti.com
State Superseded
Delegated to: Jaehoon Chung
Headers show
Series mmc: fixes for HS200/UHS core support | expand

Commit Message

Jean-Jacques Hiblot Nov. 21, 2017, 3:13 p.m. UTC 
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
 drivers/mmc/mmc-uclass.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Lukasz Majewski Nov. 22, 2017, 9:08 a.m. UTC | #1 
On Tue, 21 Nov 2017 16:13:05 +0100
Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:

> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
>  drivers/mmc/mmc-uclass.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 48fafce..9723129 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -161,8 +161,12 @@ int mmc_of_parse(const void *fdt, int node,
> struct mmc_config *cfg) cfg->host_caps |= MMC_CAP(UHS_DDR50);
>  	if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_8v"))
>  		cfg->host_caps |= MMC_CAP(MMC_DDR_52);
> +	if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_2v"))
> +		cfg->host_caps |= MMC_CAP(MMC_DDR_52);
>  	if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_8v"))
>  		cfg->host_caps |= MMC_CAP(MMC_HS_200);
> +	if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_2v"))
> +		cfg->host_caps |= MMC_CAP(MMC_HS_200);
>  
>  	return 0;
>  }

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Simon Glass Nov. 24, 2017, 10:36 p.m. UTC | #2 
Hi Jean-Jacques,

On 21 November 2017 at 08:13, Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
>  drivers/mmc/mmc-uclass.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 48fafce..9723129 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -161,8 +161,12 @@ int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)
>                 cfg->host_caps |= MMC_CAP(UHS_DDR50);
>         if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_8v"))
>                 cfg->host_caps |= MMC_CAP(MMC_DDR_52);
> +       if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_2v"))
> +               cfg->host_caps |= MMC_CAP(MMC_DDR_52);
>         if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_8v"))
>                 cfg->host_caps |= MMC_CAP(MMC_HS_200);
> +       if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_2v"))
> +               cfg->host_caps |= MMC_CAP(MMC_HS_200);

Hmm, please convert to livetree first - e.g. ofnode_read_bool()

>
>         return 0;
>  }
> --
> 1.9.1
>

Regards,
Simon
diff mbox series

Patch

diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index 48fafce..9723129 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -161,8 +161,12 @@  int mmc_of_parse(const void *fdt, int node, struct mmc_config *cfg)
 		cfg->host_caps |= MMC_CAP(UHS_DDR50);
 	if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_8v"))
 		cfg->host_caps |= MMC_CAP(MMC_DDR_52);
+	if (fdtdec_get_bool(fdt, node, "mmc-ddr-1_2v"))
+		cfg->host_caps |= MMC_CAP(MMC_DDR_52);
 	if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_8v"))
 		cfg->host_caps |= MMC_CAP(MMC_HS_200);
+	if (fdtdec_get_bool(fdt, node, "mmc-hs200-1_2v"))
+		cfg->host_caps |= MMC_CAP(MMC_HS_200);
 
 	return 0;
 }