diff mbox

ax88796: depend on HAS_IOMEM not on individual ARCHs

Message ID 1298405998-6214-1-git-send-email-mkl@pengutronix.de
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Marc Kleine-Budde Feb. 22, 2011, 8:19 p.m. UTC
Reported-by: David Miller <davem@davemloft.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---

Hello David,

this patch is available in the git repository at:
  git://git.pengutronix.de/git/mkl/linux-2.6.git net/ax88796

based on the patches already merged into net-next.

regards, Marc

 drivers/net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Miller Feb. 22, 2011, 8:37 p.m. UTC | #1
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Tue, 22 Feb 2011 21:19:58 +0100

> Reported-by: David Miller <davem@davemloft.net>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> 
> Hello David,
> 
> this patch is available in the git repository at:
>   git://git.pengutronix.de/git/mkl/linux-2.6.git net/ax88796
> 
> based on the patches already merged into net-next.

I would like you to actually build test this.

I know it's going to cause allmodconfig build errors on sparc64,
for example.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marc Kleine-Budde Feb. 22, 2011, 9:42 p.m. UTC | #2
On 02/22/2011 09:37 PM, David Miller wrote:
> I know it's going to cause allmodconfig build errors on sparc64,
> for example.

How to fix?
> drivers/net/ax88796.c:195: error: implicit declaration of function 'readsw'
> drivers/net/ax88796.c:198: error: implicit declaration of function 'readsb'

Use "ioreadX_rep" or add a "!SPARC64" to Kconfig?

Marc
David Miller Feb. 22, 2011, 10:01 p.m. UTC | #3
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Tue, 22 Feb 2011 22:42:30 +0100

> On 02/22/2011 09:37 PM, David Miller wrote:
>> I know it's going to cause allmodconfig build errors on sparc64,
>> for example.
> 
> How to fix?
>> drivers/net/ax88796.c:195: error: implicit declaration of function 'readsw'
>> drivers/net/ax88796.c:198: error: implicit declaration of function 'readsb'
> 
> Use "ioreadX_rep" or add a "!SPARC64" to Kconfig?

Make sparc64 provide the necessary interface.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f4b3927..5d7d9e7 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -237,7 +237,7 @@  source "drivers/net/arm/Kconfig"
 
 config AX88796
 	tristate "ASIX AX88796 NE2000 clone support"
-	depends on ARM || MIPS || SUPERH
+	depends on HAS_IOMEM
 	select PHYLIB
 	select MDIO_BITBANG
 	help