| Message ID | 1511100331-5895-1-git-send-email-yanjun.zhu@oracle.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next,1/1] forcedeth: replace pci_unmap_page with dma_unmap_page | expand |
From: Zhu Yanjun <yanjun.zhu@oracle.com> Date: Sun, 19 Nov 2017 09:05:31 -0500 > @@ -1986,7 +1986,7 @@ static void nv_unmap_txskb(struct fe_priv *np, struct nv_skb_map *tx_skb) > tx_skb->dma_len, > DMA_TO_DEVICE); > else > - pci_unmap_page(np->pci_dev, tx_skb->dma, > + dma_unmap_page(&np->pci_dev->dev, tx_skb->dma, > tx_skb->dma_len, > PCI_DMA_TODEVICE); So you're going to call a dma_*() function using a PCI_DMA_* direction flag? Please correct this. Thank you.
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index ac8439c..0febe41 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -1986,7 +1986,7 @@ static void nv_unmap_txskb(struct fe_priv *np, struct nv_skb_map *tx_skb) tx_skb->dma_len, DMA_TO_DEVICE); else - pci_unmap_page(np->pci_dev, tx_skb->dma, + dma_unmap_page(&np->pci_dev->dev, tx_skb->dma, tx_skb->dma_len, PCI_DMA_TODEVICE); tx_skb->dma = 0;
The function pci_unmap_page is obsolete. So it is replaced with the function dma_unmap_page. CC: Srinivas Eeda <srinivas.eeda@oracle.com> CC: Joe Jin <joe.jin@oracle.com> CC: Junxiao Bi <junxiao.bi@oracle.com> Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com> --- drivers/net/ethernet/nvidia/forcedeth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)