| Message ID | 20171119123432.8894-1-rvarsha016@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | [nft] tests: shell: Add test for IPv4 Mapped IPv6 address. | expand |
On Sun, Nov 19, 2017 at 06:04:32PM +0530, Varsha Rao wrote: > This patch adds test case for IPv4 Mapped IPv6 address and renames > file 0025named_limit_0 to 0026named_limit_0. Applied, thanks Varsha. Please, next time, send one patch for each thing. It's a good practise to stick to one single patch per logical change. In other words, if you see yourself saying in the patch description something like: "This patch is doing X and Y", then it means X needs one single patch for it, and Y another one. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 20, 2017 at 6:58 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > On Sun, Nov 19, 2017 at 06:04:32PM +0530, Varsha Rao wrote: >> This patch adds test case for IPv4 Mapped IPv6 address and renames >> file 0025named_limit_0 to 0026named_limit_0. > > Applied, thanks Varsha. > > Please, next time, send one patch for each thing. It's a good practise > to stick to one single patch per logical change. > > In other words, if you see yourself saying in the patch description > something like: "This patch is doing X and Y", then it means X needs > one single patch for it, and Y another one. Sorry, as no code was changed, I did not make a new patch for it. Thank you for the clarification. Thanks, Varsha -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Pablo, On Sun, Nov 19, 2017 at 6:04 PM, Varsha Rao <rvarsha016@gmail.com> wrote: > This patch adds test case for IPv4 Mapped IPv6 address and renames > file 0025named_limit_0 to 0026named_limit_0. > > Signed-off-by: Varsha Rao <rvarsha016@gmail.com> > --- > rename to tests/shell/testcases/sets/0026named_limit_0 > diff --git a/tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 b/tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 > new file mode 100755 There seems to be a small problem with applied patch. It has file mode as 100644 instead of 100755. Should I send a patch for it? Thanks, Varsha -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/shell/testcases/sets/0025named_limit_0 b/tests/shell/testcases/sets/0026named_limit_0 similarity index 100% rename from tests/shell/testcases/sets/0025named_limit_0 rename to tests/shell/testcases/sets/0026named_limit_0 diff --git a/tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 b/tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 new file mode 100755 index 0000000..5420fbf --- /dev/null +++ b/tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 @@ -0,0 +1,25 @@ +#!/bin/bash + +# Tests IPv4 Mapped IPv6 addresses. + +set -e + +tmpfile=$(mktemp) +if [ ! -w $tmpfile ] ; then + echo "Failed to create tmp file" >&2 + exit 0 +fi + +trap "rm -rf $tmpfile" EXIT # cleanup if aborted + +echo " +table inet t { + set s { + type ipv6_addr + flags interval + elements = { ::ffff:0.0.0.0/96 } + } +} +" > $tmpfile + +$NFT -f $tmpfile
This patch adds test case for IPv4 Mapped IPv6 address and renames file 0025named_limit_0 to 0026named_limit_0. Signed-off-by: Varsha Rao <rvarsha016@gmail.com> --- .../sets/{0025named_limit_0 => 0026named_limit_0} | 0 tests/shell/testcases/sets/0027ipv6_maps_ipv4_0 | 25 ++++++++++++++++++++++ 2 files changed, 25 insertions(+) rename tests/shell/testcases/sets/{0025named_limit_0 => 0026named_limit_0} (100%) create mode 100755 tests/shell/testcases/sets/0027ipv6_maps_ipv4_0