| Message ID | 1510959741-31109-8-git-send-email-yang.s@alibaba-inc.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/8] mm: kmemleak: remove unused hardirq.h | expand |
Hi folks, Any comment on this one? Thanks, Yang On 11/17/17 3:02 PM, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by TIPC at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> > Cc: Jon Maloy <jon.maloy@ericsson.com> > Cc: Ying Xue <ying.xue@windriver.com> > Cc: "David S. Miller" <davem@davemloft.net> > --- > net/tipc/core.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/tipc/core.h b/net/tipc/core.h > index 5cc5398..099e072 100644 > --- a/net/tipc/core.h > +++ b/net/tipc/core.h > @@ -49,7 +49,6 @@ > #include <linux/uaccess.h> > #include <linux/interrupt.h> > #include <linux/atomic.h> > -#include <asm/hardirq.h> > #include <linux/netdevice.h> > #include <linux/in.h> > #include <linux/list.h> >
> -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Yang Shi > Sent: Thursday, December 07, 2017 14:16 > To: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org; linux-fsdevel@vger.kernel.org; linux- > crypto@vger.kernel.org; netdev@vger.kernel.org; Jon Maloy > <jon.maloy@ericsson.com>; Ying Xue <ying.xue@windriver.com>; David S. > Miller <davem@davemloft.net> > Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h > > Hi folks, > > Any comment on this one? If it compiles it is ok with me. Don't know why it was put there in the first place. ///jon > > Thanks, > Yang > > > On 11/17/17 3:02 PM, Yang Shi wrote: > > Preempt counter APIs have been split out, currently, hardirq.h just > > includes irq_enter/exit APIs which are not used by TIPC at all. > > > > So, remove the unused hardirq.h. > > > > Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> > > Cc: Jon Maloy <jon.maloy@ericsson.com> > > Cc: Ying Xue <ying.xue@windriver.com> > > Cc: "David S. Miller" <davem@davemloft.net> > > --- > > net/tipc/core.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072 > > 100644 > > --- a/net/tipc/core.h > > +++ b/net/tipc/core.h > > @@ -49,7 +49,6 @@ > > #include <linux/uaccess.h> > > #include <linux/interrupt.h> > > #include <linux/atomic.h> > > -#include <asm/hardirq.h> > > #include <linux/netdevice.h> > > #include <linux/in.h> > > #include <linux/list.h> > >
On 12/7/17 11:20 AM, Jon Maloy wrote: > > >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev- >> owner@vger.kernel.org] On Behalf Of Yang Shi >> Sent: Thursday, December 07, 2017 14:16 >> To: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org; linux-fsdevel@vger.kernel.org; linux- >> crypto@vger.kernel.org; netdev@vger.kernel.org; Jon Maloy >> <jon.maloy@ericsson.com>; Ying Xue <ying.xue@windriver.com>; David S. >> Miller <davem@davemloft.net> >> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h >> >> Hi folks, >> >> Any comment on this one? > > If it compiles it is ok with me. Don't know why it was put there in the first place. Yes, it does compile. Yang > > ///jon > >> >> Thanks, >> Yang >> >> >> On 11/17/17 3:02 PM, Yang Shi wrote: >>> Preempt counter APIs have been split out, currently, hardirq.h just >>> includes irq_enter/exit APIs which are not used by TIPC at all. >>> >>> So, remove the unused hardirq.h. >>> >>> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> >>> Cc: Jon Maloy <jon.maloy@ericsson.com> >>> Cc: Ying Xue <ying.xue@windriver.com> >>> Cc: "David S. Miller" <davem@davemloft.net> >>> --- >>> net/tipc/core.h | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072 >>> 100644 >>> --- a/net/tipc/core.h >>> +++ b/net/tipc/core.h >>> @@ -49,7 +49,6 @@ >>> #include <linux/uaccess.h> >>> #include <linux/interrupt.h> >>> #include <linux/atomic.h> >>> -#include <asm/hardirq.h> >>> #include <linux/netdevice.h> >>> #include <linux/in.h> >>> #include <linux/list.h> >>>
On 11/18/2017 07:02 AM, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by TIPC at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> > Cc: Jon Maloy <jon.maloy@ericsson.com> > Cc: Ying Xue <ying.xue@windriver.com> > Cc: "David S. Miller" <davem@davemloft.net> Tested-by: Ying Xue <ying.xue@windriver.com> Acked-by: Ying Xue <ying.xue@windriver.com> > --- > net/tipc/core.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/tipc/core.h b/net/tipc/core.h > index 5cc5398..099e072 100644 > --- a/net/tipc/core.h > +++ b/net/tipc/core.h > @@ -49,7 +49,6 @@ > #include <linux/uaccess.h> > #include <linux/interrupt.h> > #include <linux/atomic.h> > -#include <asm/hardirq.h> > #include <linux/netdevice.h> > #include <linux/in.h> > #include <linux/list.h> >
Hi David, Any more comment on this change? Thanks, Yang On 12/7/17 5:40 PM, Ying Xue wrote: > On 11/18/2017 07:02 AM, Yang Shi wrote: >> Preempt counter APIs have been split out, currently, hardirq.h just >> includes irq_enter/exit APIs which are not used by TIPC at all. >> >> So, remove the unused hardirq.h. >> >> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> >> Cc: Jon Maloy <jon.maloy@ericsson.com> >> Cc: Ying Xue <ying.xue@windriver.com> >> Cc: "David S. Miller" <davem@davemloft.net> > > Tested-by: Ying Xue <ying.xue@windriver.com> > Acked-by: Ying Xue <ying.xue@windriver.com> > >> --- >> net/tipc/core.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/tipc/core.h b/net/tipc/core.h >> index 5cc5398..099e072 100644 >> --- a/net/tipc/core.h >> +++ b/net/tipc/core.h >> @@ -49,7 +49,6 @@ >> #include <linux/uaccess.h> >> #include <linux/interrupt.h> >> #include <linux/atomic.h> >> -#include <asm/hardirq.h> >> #include <linux/netdevice.h> >> #include <linux/in.h> >> #include <linux/list.h> >>
From: "Yang Shi" <yang.s@alibaba-inc.com> Date: Fri, 05 Jan 2018 06:46:48 +0800 > Any more comment on this change? These patches were not really submitted properly. If you post a series, the series goes to one destination and one tree. If they are supposed to go to multiple trees, submit them individually rather than as a series. With clear indications in the Subject lines which tree should be taking the patch. Thank you.
On 1/5/18 7:17 AM, David Miller wrote: > From: "Yang Shi" <yang.s@alibaba-inc.com> > Date: Fri, 05 Jan 2018 06:46:48 +0800 > >> Any more comment on this change? > > These patches were not really submitted properly. > > If you post a series, the series goes to one destination and > one tree. > > If they are supposed to go to multiple trees, submit them > individually rather than as a series. With clear indications > in the Subject lines which tree should be taking the patch. Thanks for the comment. I will resend the net patches in a separate series to you. Yang > > Thank you. >
diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072 100644 --- a/net/tipc/core.h +++ b/net/tipc/core.h @@ -49,7 +49,6 @@ #include <linux/uaccess.h> #include <linux/interrupt.h> #include <linux/atomic.h> -#include <asm/hardirq.h> #include <linux/netdevice.h> #include <linux/in.h> #include <linux/list.h>
Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by TIPC at all. So, remove the unused hardirq.h. Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> Cc: Jon Maloy <jon.maloy@ericsson.com> Cc: Ying Xue <ying.xue@windriver.com> Cc: "David S. Miller" <davem@davemloft.net> --- net/tipc/core.h | 1 - 1 file changed, 1 deletion(-)