| Message ID | 1510959741-31109-6-git-send-email-yang.s@alibaba-inc.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/8] mm: kmemleak: remove unused hardirq.h | expand |
Hi folks, Any comment on this one? Thanks, Yang On 11/17/17 3:02 PM, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by caif at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> > Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no> > Cc: "David S. Miller" <davem@davemloft.net> > --- > net/caif/cfpkt_skbuff.c | 1 - > net/caif/chnl_net.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c > index 71b6ab2..38c2b7a 100644 > --- a/net/caif/cfpkt_skbuff.c > +++ b/net/caif/cfpkt_skbuff.c > @@ -8,7 +8,6 @@ > > #include <linux/string.h> > #include <linux/skbuff.h> > -#include <linux/hardirq.h> > #include <linux/export.h> > #include <net/caif/cfpkt.h> > > diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c > index 922ac1d..53ecda1 100644 > --- a/net/caif/chnl_net.c > +++ b/net/caif/chnl_net.c > @@ -8,7 +8,6 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ > > #include <linux/fs.h> > -#include <linux/hardirq.h> > #include <linux/init.h> > #include <linux/module.h> > #include <linux/netdevice.h> >
Hi David, I'm not sure if CAIF is still maintained by Dmitry Tarnyagin. Do you have any comment on this one? Thanks, Yang On 12/7/17 11:13 AM, Yang Shi wrote: > Hi folks, > > Any comment on this one? > > Thanks, > Yang > > > On 11/17/17 3:02 PM, Yang Shi wrote: >> Preempt counter APIs have been split out, currently, hardirq.h just >> includes irq_enter/exit APIs which are not used by caif at all. >> >> So, remove the unused hardirq.h. >> >> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> >> Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no> >> Cc: "David S. Miller" <davem@davemloft.net> >> --- >> net/caif/cfpkt_skbuff.c | 1 - >> net/caif/chnl_net.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c >> index 71b6ab2..38c2b7a 100644 >> --- a/net/caif/cfpkt_skbuff.c >> +++ b/net/caif/cfpkt_skbuff.c >> @@ -8,7 +8,6 @@ >> #include <linux/string.h> >> #include <linux/skbuff.h> >> -#include <linux/hardirq.h> >> #include <linux/export.h> >> #include <net/caif/cfpkt.h> >> diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c >> index 922ac1d..53ecda1 100644 >> --- a/net/caif/chnl_net.c >> +++ b/net/caif/chnl_net.c >> @@ -8,7 +8,6 @@ >> #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ >> #include <linux/fs.h> >> -#include <linux/hardirq.h> >> #include <linux/init.h> >> #include <linux/module.h> >> #include <linux/netdevice.h> >>
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c index 71b6ab2..38c2b7a 100644 --- a/net/caif/cfpkt_skbuff.c +++ b/net/caif/cfpkt_skbuff.c @@ -8,7 +8,6 @@ #include <linux/string.h> #include <linux/skbuff.h> -#include <linux/hardirq.h> #include <linux/export.h> #include <net/caif/cfpkt.h> diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index 922ac1d..53ecda1 100644 --- a/net/caif/chnl_net.c +++ b/net/caif/chnl_net.c @@ -8,7 +8,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ #include <linux/fs.h> -#include <linux/hardirq.h> #include <linux/init.h> #include <linux/module.h> #include <linux/netdevice.h>
Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by caif at all. So, remove the unused hardirq.h. Signed-off-by: Yang Shi <yang.s@alibaba-inc.com> Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no> Cc: "David S. Miller" <davem@davemloft.net> --- net/caif/cfpkt_skbuff.c | 1 - net/caif/chnl_net.c | 1 - 2 files changed, 2 deletions(-)