gpio: pca953x: fix vendor prefix for PCA9654
diff mbox series

Message ID 20171116201842.006310882@cogentembedded.com
State New
Headers show
Series
  • gpio: pca953x: fix vendor prefix for PCA9654
Related show

Commit Message

Sergei Shtylyov Nov. 16, 2017, 8:18 p.m. UTC
Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
Since such prefix doesn't seem to be used in any device trees, I think we
can just fix the "compatible" string in the driver and the bindings and be
done with that...

Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
 drivers/gpio/gpio-pca953x.c                             |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Sergei Shtylyov Nov. 16, 2017, 8:32 p.m. UTC | #1
On 11/16/2017 11:18 PM, Sergei Shtylyov wrote:

> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:

    Later, of course. Could be fixed while committing, I guess?

> add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> Since such prefix doesn't seem to be used in any device trees, I think we
> can just fix the "compatible" string in the driver and the bindings and be
> done with that...
> 
> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven Nov. 17, 2017, 9:06 a.m. UTC | #2
Hi Sergei,

On Thu, Nov 16, 2017 at 9:18 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
> add onsemi,pca9654 id") made use of another, undocumented vendor prefix.

Ouch...

> Since such prefix doesn't seem to be used in any device trees, I think we
> can just fix the "compatible" string in the driver and the bindings and be
> done with that...
>
> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
>
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
>  drivers/gpio/gpio-pca953x.c                             |    2 +-

There's another (different) one in
Documentation/devicetree/bindings/misc/idt_89hpesx.txt

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Nov. 17, 2017, 10:47 a.m. UTC | #3
On 11/17/2017 12:06 PM, Geert Uytterhoeven wrote:

>> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
>> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
>> add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> 
> Ouch...
> 
>> Since such prefix doesn't seem to be used in any device trees, I think we
>> can just fix the "compatible" string in the driver and the bindings and be
>> done with that...
>>
>> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
>>
>>   Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
>>   drivers/gpio/gpio-pca953x.c                             |    2 +-
> 
> There's another (different) one in
> Documentation/devicetree/bindings/misc/idt_89hpesx.txt

    Saw that. Do you think it also should be fixed (in this patch)?

> Gr{oetje,eeting}s,
> 
>                          Geert

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Nov. 20, 2017, 6:59 p.m. UTC | #4
On Fri, Nov 17, 2017 at 01:47:04PM +0300, Sergei Shtylyov wrote:
> On 11/17/2017 12:06 PM, Geert Uytterhoeven wrote:
> 
> > > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> > > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
> > > add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> > 
> > Ouch...
> > 
> > > Since such prefix doesn't seem to be used in any device trees, I think we
> > > can just fix the "compatible" string in the driver and the bindings and be
> > > done with that...
> > > 
> > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > > 
> > > ---
> > > The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
> > > 
> > >   Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
> > >   drivers/gpio/gpio-pca953x.c                             |    2 +-
> > 
> > There's another (different) one in
> > Documentation/devicetree/bindings/misc/idt_89hpesx.txt
> 
>    Saw that. Do you think it also should be fixed (in this patch)?

IMO, separate.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Nov. 20, 2017, 7:01 p.m. UTC | #5
On Thu, Nov 16, 2017 at 11:18:32PM +0300, Sergei Shtylyov wrote:
> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
> add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> Since such prefix doesn't seem to be used in any device trees, I think we
> can just fix the "compatible" string in the driver and the bindings and be
> done with that...
> 
> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
> 
>  Documentation/devicetree/bindings/gpio/gpio-pca953x.txt |    2 +-
>  drivers/gpio/gpio-pca953x.c                             |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Nov. 30, 2017, 1:38 p.m. UTC | #6
On Thu, Nov 16, 2017 at 9:18 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:

> Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
> add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> Since such prefix doesn't seem to be used in any device trees, I think we
> can just fix the "compatible" string in the driver and the bindings and be
> done with that...
>
> Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Patch applied with Rob's ACK.

Thanks for spotting this in time.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox series

Index: linux-gpio/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
===================================================================
--- linux-gpio.orig/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
+++ linux-gpio/Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
@@ -27,7 +27,7 @@  Required properties:
 	ti,tca6424
 	ti,tca9539
 	ti,tca9554
-	onsemi,pca9654
+	onnn,pca9654
 	exar,xra1202
 
 Optional properties:
Index: linux-gpio/drivers/gpio/gpio-pca953x.c
===================================================================
--- linux-gpio.orig/drivers/gpio/gpio-pca953x.c
+++ linux-gpio/drivers/gpio/gpio-pca953x.c
@@ -947,7 +947,7 @@  static const struct of_device_id pca953x
 	{ .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
 	{ .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
 
-	{ .compatible = "onsemi,pca9654", .data = OF_953X( 8, PCA_INT), },
+	{ .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
 
 	{ .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },
 	{ }