dt-bindings: i2c: eeprom: Add Renesas R1EX24128

Message ID 1510839994-12473-1-git-send-email-geert+renesas@glider.be
State New
Delegated to: Bartosz Golaszewski
Headers show
Series
  • dt-bindings: i2c: eeprom: Add Renesas R1EX24128
Related show

Commit Message

Geert Uytterhoeven Nov. 16, 2017, 1:46 p.m.
Document the compatible value for the Renesas R1EX24128ASAS0A two-wire
serial interface EEPROM, so it can be used in DTS files without causing
checkpatch warnings.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring Nov. 17, 2017, 8:30 p.m. | #1
On Thu, Nov 16, 2017 at 02:46:34PM +0100, Geert Uytterhoeven wrote:
> Document the compatible value for the Renesas R1EX24128ASAS0A two-wire
> serial interface EEPROM, so it can be used in DTS files without causing
> checkpatch warnings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>
Wolfram Sang Nov. 18, 2017, 7:38 a.m. | #2
On Thu, Nov 16, 2017 at 02:46:34PM +0100, Geert Uytterhoeven wrote:
> Document the compatible value for the Renesas R1EX24128ASAS0A two-wire
> serial interface EEPROM, so it can be used in DTS files without causing
> checkpatch warnings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Wolfram Sang Nov. 27, 2017, 6:05 p.m. | #3
Bartosz,

>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +-

I just noticed this file is missing in the AT24 entry in MAINTAINERS. I
wanted to prepare a patch for that but then I was wondering if the name
"eeprom.txt" is really suitable? I have doubts. Would "at24.txt" be a
better name maybe? Rob?

Kind regards,

   Wolfram
Geert Uytterhoeven Nov. 27, 2017, 6:18 p.m. | #4
On Mon, Nov 27, 2017 at 7:05 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +-
>
> I just noticed this file is missing in the AT24 entry in MAINTAINERS. I
> wanted to prepare a patch for that but then I was wondering if the name
> "eeprom.txt" is really suitable? I have doubts. Would "at24.txt" be a
> better name maybe? Rob?

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Bartosz Golaszewski Nov. 27, 2017, 7:06 p.m. | #5
2017-11-27 19:05 GMT+01:00 Wolfram Sang <wsa@the-dreams.de>:
> Bartosz,
>
>>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 +-
>
> I just noticed this file is missing in the AT24 entry in MAINTAINERS. I
> wanted to prepare a patch for that but then I was wondering if the name
> "eeprom.txt" is really suitable? I have doubts. Would "at24.txt" be a
> better name maybe? Rob?
>
> Kind regards,
>
>    Wolfram
>

Yes, it definitely should be called at24.txt - especially that we have
the legacy eeprom module in drivers/misc/eeprom/eeprom.c which has
nothing to do with the bindings in eeprom.txt.

Acked-in-advance-by: Bartosz Golaszewski <brgl@bgdev.pl>

Thanks,
Bartosz

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
index 27f2bc15298a46fc..dab813cfdaa76b96 100644
--- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
+++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
@@ -14,7 +14,7 @@  Required properties:
 
 	"ramtron,24c64"
 
-	"renesas,r1ex24002"
+	"renesas,r1ex24002", "renesas,r1ex24128"
 
 	The following manufacturers values have been deprecated:
 	"at", "at24"