diff mbox series

[U-Boot,v2,1/6] pico-imx6ul: Move dfu_alt_info to CONFIG_DFU_ENV_SETTINGS variable

Message ID 20171116115950.21942-1-otavio@ossystems.com.br
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [U-Boot,v2,1/6] pico-imx6ul: Move dfu_alt_info to CONFIG_DFU_ENV_SETTINGS variable | expand

Commit Message

Otavio Salvador Nov. 16, 2017, 11:59 a.m. UTC
From: Fabio Berton <fabio.berton@ossystems.com.br>

Create CONFIG_DFU_ENV_SETTINGS to set dfu environment settings to
improve human readable code.

Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2: None

 include/configs/pico-imx6ul.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Lukasz Majewski Nov. 17, 2017, 9:34 a.m. UTC | #1
On Thu, 16 Nov 2017 09:59:44 -0200
Otavio Salvador <otavio@ossystems.com.br> wrote:

> From: Fabio Berton <fabio.berton@ossystems.com.br>
> 
> Create CONFIG_DFU_ENV_SETTINGS to set dfu environment settings to
> improve human readable code.
> 
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
> Changes in v2: None
> 
>  include/configs/pico-imx6ul.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/pico-imx6ul.h
> b/include/configs/pico-imx6ul.h index 75658fd489..d4b29e3950 100644
> --- a/include/configs/pico-imx6ul.h
> +++ b/include/configs/pico-imx6ul.h
> @@ -47,6 +47,9 @@
>  #define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_16M
>  #define DFU_DEFAULT_POLL_TIMEOUT 300
>  
> +#define CONFIG_DFU_ENV_SETTINGS \
> +	"dfu_alt_info=boot raw 0x2 0x400 mmcpart 1\0" \
> +
>  #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
>  
>  #define CONFIG_EXTRA_ENV_SETTINGS \
> @@ -60,7 +63,7 @@
>  	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
>  	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
>  	"mmcautodetect=yes\0" \
> -	"dfu_alt_info=boot raw 0x2 0x400 mmcpart 1\0" \
> +	CONFIG_DFU_ENV_SETTINGS \
>  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
>  		"root=${mmcroot}\0" \
>  	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
> ${image}\0" \

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Stefano Babic Nov. 20, 2017, 8:56 a.m. UTC | #2
Hi Otavio,

On 16/11/2017 12:59, Otavio Salvador wrote:
> From: Fabio Berton <fabio.berton@ossystems.com.br>
> 
> Create CONFIG_DFU_ENV_SETTINGS to set dfu environment settings to
> improve human readable code.
> 
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 

Whole series applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/include/configs/pico-imx6ul.h b/include/configs/pico-imx6ul.h
index 75658fd489..d4b29e3950 100644
--- a/include/configs/pico-imx6ul.h
+++ b/include/configs/pico-imx6ul.h
@@ -47,6 +47,9 @@ 
 #define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_16M
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
+#define CONFIG_DFU_ENV_SETTINGS \
+	"dfu_alt_info=boot raw 0x2 0x400 mmcpart 1\0" \
+
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
@@ -60,7 +63,7 @@ 
 	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
 	"mmcautodetect=yes\0" \
-	"dfu_alt_info=boot raw 0x2 0x400 mmcpart 1\0" \
+	CONFIG_DFU_ENV_SETTINGS \
 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
 		"root=${mmcroot}\0" \
 	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \