[Artful] UBUNTU: [Config] CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH=n
diff mbox series

Message ID 1510822243-6940-1-git-send-email-hui.wang@canonical.com
State New
Headers show
Series
  • [Artful] UBUNTU: [Config] CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH=n
Related show

Commit Message

Hui Wang Nov. 16, 2017, 8:50 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1732627

The author of this config (pierre-louis.bossart@linux.intel.com)
suggested that we should disable this config from ubuntu artful
kernel, he said, "this is really for test environments or platforms
with a connector. I don't think it should be enabled by default
(better to fail the probe rather than get questions from users that
they have no sound)."

I also investigated this issue on my own, if our kernel is running on
a platform which has a codec and the codec is supported by the
existing driver, enabling this config will not bring side effect;
if the platform has a codec but the codec is not supported by existing
driver yet, the driver will fallback to this NOCODEC_MACH if this
config is enabled, and snd-soc-sst-byt-cht-nocodec.ko will be loaded
into the kernel, then user is easily confused that the kernel driver
is loaded but I can't hear sound from the codec.

Signed-off-by: Hui Wang <hui.wang@canonical.com>
---

This patch is only for artful kernel, since this config option is not
existed in xenial and zesty kernel yet.

 debian.master/config/annotations          | 2 +-
 debian.master/config/config.common.ubuntu | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Kleber Souza Nov. 16, 2017, 3:35 p.m. UTC | #1
On 11/16/17 09:50, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1732627
> 
> The author of this config (pierre-louis.bossart@linux.intel.com)
> suggested that we should disable this config from ubuntu artful
> kernel, he said, "this is really for test environments or platforms
> with a connector. I don't think it should be enabled by default
> (better to fail the probe rather than get questions from users that
> they have no sound)."
> 
> I also investigated this issue on my own, if our kernel is running on
> a platform which has a codec and the codec is supported by the
> existing driver, enabling this config will not bring side effect;
> if the platform has a codec but the codec is not supported by existing
> driver yet, the driver will fallback to this NOCODEC_MACH if this
> config is enabled, and snd-soc-sst-byt-cht-nocodec.ko will be loaded
> into the kernel, then user is easily confused that the kernel driver
> is loaded but I can't hear sound from the codec.
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
> 
> This patch is only for artful kernel, since this config option is not
> existed in xenial and zesty kernel yet.
> 
>  debian.master/config/annotations          | 2 +-
>  debian.master/config/config.common.ubuntu | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 254a059..0dda4f7 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -6580,7 +6580,7 @@ CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH        policy<{'amd64': 'm', 'i386': 'm
>  CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
> -CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'm', 'i386': 'm'}>
> +CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'n', 'i386': 'n'}>
>  CONFIG_SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_SKL_RT286_MACH             policy<{'amd64': 'm', 'i386': 'm'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index ec9ec98..48bea12 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -8284,7 +8284,7 @@ CONFIG_SND_SOC_INTEL_BYTCR_RT5640_MACH=m
>  CONFIG_SND_SOC_INTEL_BYTCR_RT5651_MACH=m
>  CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH=m
>  CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH=m
> -CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH=m
> +# CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH is not set
>  CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m
>  CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH=m
>  CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH=m
>
Seth Forshee Nov. 16, 2017, 10:14 p.m. UTC | #2
On Thu, Nov 16, 2017 at 04:50:43PM +0800, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1732627
> 
> The author of this config (pierre-louis.bossart@linux.intel.com)
> suggested that we should disable this config from ubuntu artful
> kernel, he said, "this is really for test environments or platforms
> with a connector. I don't think it should be enabled by default
> (better to fail the probe rather than get questions from users that
> they have no sound)."
> 
> I also investigated this issue on my own, if our kernel is running on
> a platform which has a codec and the codec is supported by the
> existing driver, enabling this config will not bring side effect;
> if the platform has a codec but the codec is not supported by existing
> driver yet, the driver will fallback to this NOCODEC_MACH if this
> config is enabled, and snd-soc-sst-byt-cht-nocodec.ko will be loaded
> into the kernel, then user is easily confused that the kernel driver
> is loaded but I can't hear sound from the codec.
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Also applied to unstable/master.
Stefan Bader Nov. 20, 2017, 11:17 a.m. UTC | #3
On 16.11.2017 09:50, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1732627
> 
> The author of this config (pierre-louis.bossart@linux.intel.com)
> suggested that we should disable this config from ubuntu artful
> kernel, he said, "this is really for test environments or platforms
> with a connector. I don't think it should be enabled by default
> (better to fail the probe rather than get questions from users that
> they have no sound)."
> 
> I also investigated this issue on my own, if our kernel is running on
> a platform which has a codec and the codec is supported by the
> existing driver, enabling this config will not bring side effect;
> if the platform has a codec but the codec is not supported by existing
> driver yet, the driver will fallback to this NOCODEC_MACH if this
> config is enabled, and snd-soc-sst-byt-cht-nocodec.ko will be loaded
> into the kernel, then user is easily confused that the kernel driver
> is loaded but I can't hear sound from the codec.
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> 
> This patch is only for artful kernel, since this config option is not
> existed in xenial and zesty kernel yet.
> 
>  debian.master/config/annotations          | 2 +-
>  debian.master/config/config.common.ubuntu | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 254a059..0dda4f7 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -6580,7 +6580,7 @@ CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH        policy<{'amd64': 'm', 'i386': 'm
>  CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
> -CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'm', 'i386': 'm'}>
> +CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'n', 'i386': 'n'}>
>  CONFIG_SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH policy<{'amd64': 'm', 'i386': 'm'}>
>  CONFIG_SND_SOC_INTEL_SKL_RT286_MACH             policy<{'amd64': 'm', 'i386': 'm'}>
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index ec9ec98..48bea12 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -8284,7 +8284,7 @@ CONFIG_SND_SOC_INTEL_BYTCR_RT5640_MACH=m
>  CONFIG_SND_SOC_INTEL_BYTCR_RT5651_MACH=m
>  CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH=m
>  CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH=m
> -CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH=m
> +# CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH is not set
>  CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m
>  CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH=m
>  CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH=m
> 
Applied to Artful master-next. Thanks.

Patch
diff mbox series

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 254a059..0dda4f7 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -6580,7 +6580,7 @@  CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH        policy<{'amd64': 'm', 'i386': 'm
 CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
 CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
 CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH        policy<{'amd64': 'm', 'i386': 'm'}>
-CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'm', 'i386': 'm'}>
+CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH       policy<{'amd64': 'n', 'i386': 'n'}>
 CONFIG_SND_SOC_INTEL_KBL_RT5663_MAX98927_MACH   policy<{'amd64': 'm', 'i386': 'm'}>
 CONFIG_SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH policy<{'amd64': 'm', 'i386': 'm'}>
 CONFIG_SND_SOC_INTEL_SKL_RT286_MACH             policy<{'amd64': 'm', 'i386': 'm'}>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index ec9ec98..48bea12 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -8284,7 +8284,7 @@  CONFIG_SND_SOC_INTEL_BYTCR_RT5640_MACH=m
 CONFIG_SND_SOC_INTEL_BYTCR_RT5651_MACH=m
 CONFIG_SND_SOC_INTEL_BYT_CHT_DA7213_MACH=m
 CONFIG_SND_SOC_INTEL_BYT_CHT_ES8316_MACH=m
-CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH=m
+# CONFIG_SND_SOC_INTEL_BYT_CHT_NOCODEC_MACH is not set
 CONFIG_SND_SOC_INTEL_CHT_BSW_MAX98090_TI_MACH=m
 CONFIG_SND_SOC_INTEL_CHT_BSW_RT5645_MACH=m
 CONFIG_SND_SOC_INTEL_CHT_BSW_RT5672_MACH=m