diff mbox series

Fix PowerPC testsuite not to look for *.c*~ files

Message ID 20171116005124.GA31700@ibm-tiger.the-meissners.org
State New
Headers show
Series Fix PowerPC testsuite not to look for *.c*~ files | expand

Commit Message

Michael Meissner Nov. 16, 2017, 12:51 a.m. UTC 
I was back-porting some changes to the IBM Advance Toolchain branch, and I was
doing this via creating a patch file, and applying the patch output.  I tend to
always use the -b option to patch to create a backup file.  I had new failures,
since the new files the bfp, dfp, and vfu sub-directories created an empty
*.c.~1~ file, and the .exp tried to run it as a test.  Since we don't have any
non C files in those directories, I changed the test to just *.exp.  I verified
that we get the same number of failures, successes, etc. with the patch applied
and without it being applied.  Can I check this into the trunk?

[gcc/testsuite]
2017-11-15  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* gcc.target/powerpc/bfp/bfp.exp: Look for *.c files, not *.c*
	files to prevent ~ files from getting recognized.
	* gcc.target/powerpc/dfp/dfp.exp: Likewise.
	* gcc.target/powerpc/vsu/vsu.exp: Likewise.

Comments

Segher Boessenkool Nov. 16, 2017, 10:21 a.m. UTC | #1 
Hi!

On Wed, Nov 15, 2017 at 07:51:24PM -0500, Michael Meissner wrote:
> I was back-porting some changes to the IBM Advance Toolchain branch, and I was
> doing this via creating a patch file, and applying the patch output.  I tend to
> always use the -b option to patch to create a backup file.  I had new failures,
> since the new files the bfp, dfp, and vfu sub-directories created an empty
> *.c.~1~ file, and the .exp tried to run it as a test.  Since we don't have any
> non C files in those directories, I changed the test to just *.exp.  I verified
> that we get the same number of failures, successes, etc. with the patch applied
> and without it being applied.  Can I check this into the trunk?
> 
> [gcc/testsuite]
> 2017-11-15  Michael Meissner  <meissner@linux.vnet.ibm.com>
> 
> 	* gcc.target/powerpc/bfp/bfp.exp: Look for *.c files, not *.c*
> 	files to prevent ~ files from getting recognized.
> 	* gcc.target/powerpc/dfp/dfp.exp: Likewise.
> 	* gcc.target/powerpc/vsu/vsu.exp: Likewise.

And these are the only three testsuites with this problem (in powerpc/), and
we do not have any *.c* files other than *.c .  Okay for trunk, thanks!


Segher
diff mbox series

Patch

Index: gcc/testsuite/gcc.target/powerpc/bfp/bfp.exp
===================================================================
--- gcc/testsuite/gcc.target/powerpc/bfp/bfp.exp	(revision 254782)
+++ gcc/testsuite/gcc.target/powerpc/bfp/bfp.exp	(working copy)
@@ -34,7 +34,7 @@  load_lib torture-options.exp
 # Initialize.
 dg-init
 
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c*]] "" $DEFAULT_CFLAGS
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] "" $DEFAULT_CFLAGS
 
 # All done.
 dg-finish
Index: gcc/testsuite/gcc.target/powerpc/dfp/dfp.exp
===================================================================
--- gcc/testsuite/gcc.target/powerpc/dfp/dfp.exp	(revision 254782)
+++ gcc/testsuite/gcc.target/powerpc/dfp/dfp.exp	(working copy)
@@ -33,7 +33,7 @@  load_lib torture-options.exp
 # Initialize.
 dg-init
 
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c*]] "" $DEFAULT_CFLAGS
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] "" $DEFAULT_CFLAGS
 
 # All done.
 dg-finish
Index: gcc/testsuite/gcc.target/powerpc/vsu/vsu.exp
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vsu/vsu.exp	(revision 254782)
+++ gcc/testsuite/gcc.target/powerpc/vsu/vsu.exp	(working copy)
@@ -34,7 +34,7 @@  load_lib torture-options.exp
 # Initialize.
 dg-init
 
-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c*]] "" $DEFAULT_CFLAGS
+dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] "" $DEFAULT_CFLAGS
 
 # All done.
 dg-finish