[2/3] e1000e: Alert the user that C-states will be disabled by enabling jumbo frames

Message ID 20171114235133.14755-1-mattst88@gmail.com
State Under Review
Delegated to: Jeff Kirsher
Headers show
Series
  • Untitled series #13593
Related show

Commit Message

Matt Turner Nov. 14, 2017, 11:51 p.m.
From: Matt Turner <matt.turner@intel.com>

I personally spent a long time trying to decypher why my CPU would not
reach deeper C-states. Let's just tell the next user what's going on.

Signed-off-by: Matt Turner <matt.turner@intel.com>
---
v2: Per Shannon, put string on one line for easier grepping

 drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Shannon Nelson Nov. 15, 2017, 4:48 p.m. | #1
On 11/14/2017 3:51 PM, Matt Turner wrote:
> From: Matt Turner <matt.turner@intel.com>
> 
> I personally spent a long time trying to decypher why my CPU would not
> reach deeper C-states. Let's just tell the next user what's going on.
> 
> Signed-off-by: Matt Turner <matt.turner@intel.com>
> ---
> v2: Per Shannon, put string on one line for easier grepping

Acked-by: Shannon Nelson <shannon.nelson@oracle.com>

> 
>   drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 286d0277284e..31577dad22cb 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -3288,6 +3288,8 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
>   			ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
>   		}
>   
> +		dev_info(&adapter->pdev->dev,
> +			 "Some CPU C-states have been disabled in order to enable jumbo frames\n");
>   		pm_qos_update_request(&adapter->pm_qos_req, lat);
>   	} else {
>   		pm_qos_update_request(&adapter->pm_qos_req,
>

Patch

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 286d0277284e..31577dad22cb 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -3288,6 +3288,8 @@  static void e1000_configure_rx(struct e1000_adapter *adapter)
 			ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
 		}
 
+		dev_info(&adapter->pdev->dev,
+			 "Some CPU C-states have been disabled in order to enable jumbo frames\n");
 		pm_qos_update_request(&adapter->pm_qos_req, lat);
 	} else {
 		pm_qos_update_request(&adapter->pm_qos_req,