[next,S82-V4,5/9] i40e: track id can be 0

Message ID 20171114120052.86665-5-alice.michael@intel.com
State Under Review
Delegated to: Jeff Kirsher
Headers show
Series
  • [next,S82-V4,1/9] i40evf: Do not clear MSI-X PBA manually
Related show

Commit Message

Alice Michael Nov. 14, 2017, noon
From: Jingjing Wu <jingjing.wu@intel.com>

track_id == 0 is valid for “read only” profiles when
profile does not have any “write” commands.

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_common.c   | 5 -----
 drivers/net/ethernet/intel/i40evf/i40e_common.c | 5 -----
 2 files changed, 10 deletions(-)

Comments

Bowers, AndrewX Nov. 16, 2017, 10:21 p.m. | #1
> -----Original Message-----

> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On

> Behalf Of Alice Michael

> Sent: Tuesday, November 14, 2017 4:01 AM

> To: Michael, Alice <alice.michael@intel.com>; intel-wired-

> lan@lists.osuosl.org

> Cc: Wu, Jingjing <jingjing.wu@intel.com>

> Subject: [Intel-wired-lan] [next PATCH S82-V4 5/9] i40e: track id can be 0

> 

> From: Jingjing Wu <jingjing.wu@intel.com>

> 

> track_id == 0 is valid for “read only” profiles when profile does not have any

> “write” commands.

> 

> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

> ---

>  drivers/net/ethernet/intel/i40e/i40e_common.c   | 5 -----

>  drivers/net/ethernet/intel/i40evf/i40e_common.c | 5 -----

>  2 files changed, 10 deletions(-)


Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

Patch

diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
index 9ef7a0c..5abc83c 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
@@ -5357,11 +5357,6 @@  i40e_write_profile(struct i40e_hw *hw, struct i40e_profile_segment *profile,
 	u32 offset = 0, info = 0;
 	u32 i;
 
-	if (!track_id) {
-		i40e_debug(hw, I40E_DEBUG_PACKAGE, "Track_id can't be 0.");
-		return I40E_NOT_SUPPORTED;
-	}
-
 	dev_cnt = profile->device_table_count;
 
 	for (i = 0; i < dev_cnt; i++) {
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c
index c1e4732..a946484 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c
@@ -1330,11 +1330,6 @@  i40evf_write_profile(struct i40e_hw *hw, struct i40e_profile_segment *profile,
 	u32 offset = 0, info = 0;
 	u32 i;
 
-	if (!track_id) {
-		i40e_debug(hw, I40E_DEBUG_PACKAGE, "Track_id can't be 0.");
-		return I40E_NOT_SUPPORTED;
-	}
-
 	dev_cnt = profile->device_table_count;
 
 	for (i = 0; i < dev_cnt; i++) {