[U-Boot] envtools: make sure version/timestamp header file are available

Message ID 20171114144718.10213-1-stefan@agner.ch
State Under Review
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] envtools: make sure version/timestamp header file are available
Related show

Commit Message

Stefan Agner Nov. 14, 2017, 2:47 p.m.
From: Stefan Agner <stefan.agner@toradex.com>

With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version")
the fw_env utilities need the version.h header file. Building only
the envtools in a pristine build directory will fail due to missing
header files.

Make sure the header files are a dependency of the envtools target.

Fixes: 84d46e7e8948 ("tools: env: allow to print U-Boot version")
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
---

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Robinson Nov. 17, 2017, 11:50 a.m. | #1
On Tue, Nov 14, 2017 at 2:47 PM, Stefan Agner <stefan@agner.ch> wrote:
> From: Stefan Agner <stefan.agner@toradex.com>
>
> With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> the fw_env utilities need the version.h header file. Building only
> the envtools in a pristine build directory will fail due to missing
> header files.
>
> Make sure the header files are a dependency of the envtools target.
>
> Fixes: 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>

Fixes build issues I saw with 2017.11 GA that I have seen.

Peter
> ---
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 67f01ad7e4..b93c2fb05b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1460,7 +1460,7 @@ checkarmreloc: u-boot
>                 false; \
>         fi
>
> -envtools: scripts_basic
> +envtools: scripts_basic $(version_h) $(timestamp_h)
>         $(Q)$(MAKE) $(build)=tools/env
>
>  tools-only: scripts_basic $(version_h) $(timestamp_h)
> --
> 2.15.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Simon Glass Nov. 20, 2017, 3:39 p.m. | #2
On 14 November 2017 at 07:47, Stefan Agner <stefan@agner.ch> wrote:
> From: Stefan Agner <stefan.agner@toradex.com>
>
> With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> the fw_env utilities need the version.h header file. Building only
> the envtools in a pristine build directory will fail due to missing
> header files.
>
> Make sure the header files are a dependency of the envtools target.
>
> Fixes: 84d46e7e8948 ("tools: env: allow to print U-Boot version")
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> ---
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Patch

diff --git a/Makefile b/Makefile
index 67f01ad7e4..b93c2fb05b 100644
--- a/Makefile
+++ b/Makefile
@@ -1460,7 +1460,7 @@  checkarmreloc: u-boot
 		false; \
 	fi
 
-envtools: scripts_basic
+envtools: scripts_basic $(version_h) $(timestamp_h)
 	$(Q)$(MAKE) $(build)=tools/env
 
 tools-only: scripts_basic $(version_h) $(timestamp_h)