[v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743

Message ID 1510653543-53770-1-git-send-email-biju.das@bp.renesas.com
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series
  • [v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
Related show

Commit Message

Biju Das Nov. 14, 2017, 9:59 a.m.
Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller
is identical to the R-Car Gen2 family.

No driver change is needed due to the fallback compatible value
"renesas,pcie-rcar-gen2".
Adding the SoC-specific compatible values here has three purposes:
1. Document which SoCs have this hardware module,
2. Allow checkpatch to validate compatible values.
3. Allow the driver to support SoC specific implementations in future
   as necessary.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v1-->v2
   Corrected RZ-G1 to RZ/G1.

 Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Simon Horman Nov. 15, 2017, 1:29 p.m. | #1
On Tue, Nov 14, 2017 at 09:59:03AM +0000, Biju Das wrote:
> Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller
> is identical to the R-Car Gen2 family.
> 
> No driver change is needed due to the fallback compatible value
> "renesas,pcie-rcar-gen2".
> Adding the SoC-specific compatible values here has three purposes:
> 1. Document which SoCs have this hardware module,
> 2. Allow checkpatch to validate compatible values.
> 3. Allow the driver to support SoC specific implementations in future
>    as necessary.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> v1-->v2
>    Corrected RZ-G1 to RZ/G1.
> 
>  Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> index 76ba3a6..1fb614e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> @@ -1,13 +1,15 @@
>  * Renesas R-Car PCIe interface
>  
>  Required properties:
> -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> +	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
>  	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
>  	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
>  	    "renesas,pcie-r8a7793" for the R8A7793 SoC;
>  	    "renesas,pcie-r8a7795" for the R8A7795 SoC;
>  	    "renesas,pcie-r8a7796" for the R8A7796 SoC;
> -	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> +	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> +				     RZ/G1 compatible device.
>  	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
>  
>  	    When compatible with the generic version, nodes must list the
> -- 
> 1.9.1
>
Biju Das Dec. 11, 2017, 1:30 p.m. | #2
Hi Bjorn Helgaas,

Does this patch look okay to you?

Regards,
Biju

> -----Original Message-----
> From: Biju Das [mailto:biju.das@bp.renesas.com]
> Sent: 14 November 2017 09:59
> To: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> Fabrizio Castro <fabrizio.castro@bp.renesas.com>; linux-pci@vger.kernel.org;
> linux-renesas-soc@vger.kernel.org; Biju Das <biju.das@bp.renesas.com>
> Subject: [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
>
> Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller is
> identical to the R-Car Gen2 family.
>
> No driver change is needed due to the fallback compatible value "renesas,pcie-
> rcar-gen2".
> Adding the SoC-specific compatible values here has three purposes:
> 1. Document which SoCs have this hardware module, 2. Allow checkpatch to
> validate compatible values.
> 3. Allow the driver to support SoC specific implementations in future
>    as necessary.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1-->v2
>    Corrected RZ-G1 to RZ/G1.
>
>  Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> index 76ba3a6..1fb614e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> @@ -1,13 +1,15 @@
>  * Renesas R-Car PCIe interface
>
>  Required properties:
> -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> +    "renesas,pcie-r8a7779" for the R8A7779 SoC;
>      "renesas,pcie-r8a7790" for the R8A7790 SoC;
>      "renesas,pcie-r8a7791" for the R8A7791 SoC;
>      "renesas,pcie-r8a7793" for the R8A7793 SoC;
>      "renesas,pcie-r8a7795" for the R8A7795 SoC;
>      "renesas,pcie-r8a7796" for the R8A7796 SoC;
> -    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> +    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> +     RZ/G1 compatible device.
>      "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
>
>      When compatible with the generic version, nodes must list the
> --
> 1.9.1



[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Bjorn Helgaas Jan. 10, 2018, 11:27 p.m. | #3
On Mon, Dec 11, 2017 at 01:30:37PM +0000, Biju Das wrote:
> Hi Bjorn Helgaas,
> 
> Does this patch look okay to you?

It's OK by me, but Lorenzo (cc'd) would handle this now.

> > -----Original Message-----
> > From: Biju Das [mailto:biju.das@bp.renesas.com]
> > Sent: 14 November 2017 09:59
> > To: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring
> > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> > Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> > <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> > Fabrizio Castro <fabrizio.castro@bp.renesas.com>; linux-pci@vger.kernel.org;
> > linux-renesas-soc@vger.kernel.org; Biju Das <biju.das@bp.renesas.com>
> > Subject: [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
> >
> > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller is
> > identical to the R-Car Gen2 family.
> >
> > No driver change is needed due to the fallback compatible value "renesas,pcie-
> > rcar-gen2".
> > Adding the SoC-specific compatible values here has three purposes:
> > 1. Document which SoCs have this hardware module, 2. Allow checkpatch to
> > validate compatible values.
> > 3. Allow the driver to support SoC specific implementations in future
> >    as necessary.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v1-->v2
> >    Corrected RZ-G1 to RZ/G1.
> >
> >  Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > index 76ba3a6..1fb614e 100644
> > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > @@ -1,13 +1,15 @@
> >  * Renesas R-Car PCIe interface
> >
> >  Required properties:
> > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> > +    "renesas,pcie-r8a7779" for the R8A7779 SoC;
> >      "renesas,pcie-r8a7790" for the R8A7790 SoC;
> >      "renesas,pcie-r8a7791" for the R8A7791 SoC;
> >      "renesas,pcie-r8a7793" for the R8A7793 SoC;
> >      "renesas,pcie-r8a7795" for the R8A7795 SoC;
> >      "renesas,pcie-r8a7796" for the R8A7796 SoC;
> > -    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> > +    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> > +     RZ/G1 compatible device.
> >      "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
> >
> >      When compatible with the generic version, nodes must list the
> > --
> > 1.9.1
> 
> 
> 
> [https://www2.renesas.eu/media/email/unicef_2017.jpg]
> 
> This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
> We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Fabrizio Castro March 6, 2018, 4:41 p.m. | #4
Ciao Lorenzo,

do you think you can take this patch?

Thanks,
Fab

> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: 10 January 2018 23:28
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Simon
> Horman <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> Fabrizio Castro <fabrizio.castro@bp.renesas.com>; linux-pci@vger.kernel.org; linux-renesas-soc@vger.kernel.org; Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com>
> Subject: Re: [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
>
> On Mon, Dec 11, 2017 at 01:30:37PM +0000, Biju Das wrote:
> > Hi Bjorn Helgaas,
> >
> > Does this patch look okay to you?
>
> It's OK by me, but Lorenzo (cc'd) would handle this now.
>
> > > -----Original Message-----
> > > From: Biju Das [mailto:biju.das@bp.renesas.com]
> > > Sent: 14 November 2017 09:59
> > > To: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring
> > > <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>
> > > Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> > > <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> > > Fabrizio Castro <fabrizio.castro@bp.renesas.com>; linux-pci@vger.kernel.org;
> > > linux-renesas-soc@vger.kernel.org; Biju Das <biju.das@bp.renesas.com>
> > > Subject: [PATCH v2] dt-bindings: PCI: rcar: Add device tree support for r8a7743
> > >
> > > Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller is
> > > identical to the R-Car Gen2 family.
> > >
> > > No driver change is needed due to the fallback compatible value "renesas,pcie-
> > > rcar-gen2".
> > > Adding the SoC-specific compatible values here has three purposes:
> > > 1. Document which SoCs have this hardware module, 2. Allow checkpatch to
> > > validate compatible values.
> > > 3. Allow the driver to support SoC specific implementations in future
> > >    as necessary.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > v1-->v2
> > >    Corrected RZ-G1 to RZ/G1.
> > >
> > >  Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > > b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > > index 76ba3a6..1fb614e 100644
> > > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> > > @@ -1,13 +1,15 @@
> > >  * Renesas R-Car PCIe interface
> > >
> > >  Required properties:
> > > -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> > > +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> > > +    "renesas,pcie-r8a7779" for the R8A7779 SoC;
> > >      "renesas,pcie-r8a7790" for the R8A7790 SoC;
> > >      "renesas,pcie-r8a7791" for the R8A7791 SoC;
> > >      "renesas,pcie-r8a7793" for the R8A7793 SoC;
> > >      "renesas,pcie-r8a7795" for the R8A7795 SoC;
> > >      "renesas,pcie-r8a7796" for the R8A7796 SoC;
> > > -    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> > > +    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> > > +     RZ/G1 compatible device.
> > >      "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
> > >
> > >      When compatible with the generic version, nodes must list the
> > > --
> > > 1.9.1
> >
> >
> >
> > [https://www2.renesas.eu/media/email/unicef_2017.jpg]
> >
> > This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further
> details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
> > We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
> >
> >
> >
> > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England
> & Wales under Registered No. 04586709.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Lorenzo Pieralisi March 6, 2018, 5:37 p.m. | #5
On Tue, Nov 14, 2017 at 09:59:03AM +0000, Biju Das wrote:
> Add support for r8a7743. The Renesas RZ/G1M(R8A7743)PCIe controller
> is identical to the R-Car Gen2 family.
> 
> No driver change is needed due to the fallback compatible value
> "renesas,pcie-rcar-gen2".
> Adding the SoC-specific compatible values here has three purposes:
> 1. Document which SoCs have this hardware module,
> 2. Allow checkpatch to validate compatible values.
> 3. Allow the driver to support SoC specific implementations in future
>    as necessary.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v1-->v2
>    Corrected RZ-G1 to RZ/G1.
> 
>  Documentation/devicetree/bindings/pci/rcar-pci.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to pci/rcar for v4.17, apologies for the delay.

Thanks,
Lorenzo

> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> index 76ba3a6..1fb614e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
> @@ -1,13 +1,15 @@
>  * Renesas R-Car PCIe interface
>  
>  Required properties:
> -compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
> +compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
> +	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
>  	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
>  	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
>  	    "renesas,pcie-r8a7793" for the R8A7793 SoC;
>  	    "renesas,pcie-r8a7795" for the R8A7795 SoC;
>  	    "renesas,pcie-r8a7796" for the R8A7796 SoC;
> -	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
> +	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
> +				     RZ/G1 compatible device.
>  	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
>  
>  	    When compatible with the generic version, nodes must list the
> -- 
> 1.9.1
>

Patch

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 76ba3a6..1fb614e 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -1,13 +1,15 @@ 
 * Renesas R-Car PCIe interface
 
 Required properties:
-compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
+compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
+	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
 	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
 	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
 	    "renesas,pcie-r8a7793" for the R8A7793 SoC;
 	    "renesas,pcie-r8a7795" for the R8A7795 SoC;
 	    "renesas,pcie-r8a7796" for the R8A7796 SoC;
-	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
+	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
+				     RZ/G1 compatible device.
 	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
 
 	    When compatible with the generic version, nodes must list the