[RFC,v2,14/26] replay/replay.c: bump REPLAY_VERSION again

Message ID 20171114081750.27640.53609.stgit@pasha-VirtualBox
State New
Headers show
Series
  • replay additions
Related show

Commit Message

Pavel Dovgalyuk Nov. 14, 2017, 8:17 a.m.
From: Alex Bennée <alex.bennee@linaro.org>

This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the
replay file format. Also add a comment about this to
replay-internal.h.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>

---
 replay/replay-internal.h |    2 +-
 replay/replay.c          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Paolo Bonzini Nov. 14, 2017, 1:35 p.m. | #1
On 14/11/2017 09:17, Pavel Dovgalyuk wrote:
> From: Alex Bennée <alex.bennee@linaro.org>
> 
> This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the
> replay file format. Also add a comment about this to
> replay-internal.h.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> 
> ---
>  replay/replay-internal.h |    2 +-
>  replay/replay.c          |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/replay/replay-internal.h b/replay/replay-internal.h
> index be96d7e..8e4c701 100644
> --- a/replay/replay-internal.h
> +++ b/replay/replay-internal.h
> @@ -12,7 +12,7 @@
>   *
>   */
>  
> -
> +/* Any changes to order/number of events will need to bump REPLAY_VERSION */
>  enum ReplayEvents {
>      /* for instruction event */
>      EVENT_INSTRUCTION,
> diff --git a/replay/replay.c b/replay/replay.c
> index ff58a5a..4f24498 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -22,7 +22,7 @@
>  
>  /* Current version of the replay mechanism.
>     Increase it when file format changes. */
> -#define REPLAY_VERSION              0xe02006
> +#define REPLAY_VERSION              0xe02007
>  /* Size of replay log header */
>  #define HEADER_SIZE                 (sizeof(uint32_t) + sizeof(uint64_t))
>  
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Patch

diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index be96d7e..8e4c701 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -12,7 +12,7 @@ 
  *
  */
 
-
+/* Any changes to order/number of events will need to bump REPLAY_VERSION */
 enum ReplayEvents {
     /* for instruction event */
     EVENT_INSTRUCTION,
diff --git a/replay/replay.c b/replay/replay.c
index ff58a5a..4f24498 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -22,7 +22,7 @@ 
 
 /* Current version of the replay mechanism.
    Increase it when file format changes. */
-#define REPLAY_VERSION              0xe02006
+#define REPLAY_VERSION              0xe02007
 /* Size of replay log header */
 #define HEADER_SIZE                 (sizeof(uint32_t) + sizeof(uint64_t))