[v2,6/7] quota: swapping s_prj_quota_inum superblock field

Message ID 20171114070440.79510-7-artem.blagodarenko@gmail.com
State New
Headers show
Series
  • 64bit inode e2fsprogs support
Related show

Commit Message

Artem Blagodarenko Nov. 14, 2017, 7:04 a.m.
ext2fs_swap_super() swaps s_usr_quota_inum and
s_grp_quota_inum fields but not s_prj_quota_inum.

This patch adds s_prj_quota_inum swapping.

Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>`
---
 lib/ext2fs/swapfs.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andreas Dilger Nov. 20, 2017, 9:25 p.m. | #1
On Nov 14, 2017, at 12:04 AM, Artem Blagodarenko <artem.blagodarenko@gmail.com> wrote:
> 
> ext2fs_swap_super() swaps s_usr_quota_inum and
> s_grp_quota_inum fields but not s_prj_quota_inum.
> 
> This patch adds s_prj_quota_inum swapping.
> 
> Lustre-bug: https://jira.hpdd.intel.com/browse/LU-9309
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>

You can add my:

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

I would suggest this patch just be submitted separately, since it is a
bug fix that could go into the "maint" branch along with other project
quota functionality, and doesn't really relate to the inode64 feature.

> ---
> lib/ext2fs/swapfs.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ext2fs/swapfs.c b/lib/ext2fs/swapfs.c
> index b7c01005..60cdf124 100644
> --- a/lib/ext2fs/swapfs.c
> +++ b/lib/ext2fs/swapfs.c
> @@ -81,6 +81,7 @@ void ext2fs_swap_super(struct ext2_super_block * sb)
> 	sb->s_snapshot_r_blocks_count =
> 		ext2fs_swab64(sb->s_snapshot_r_blocks_count);
> 	sb->s_snapshot_list = ext2fs_swab32(sb->s_snapshot_list);
> +	sb->s_prj_quota_inum = ext2fs_swab32(sb->s_prj_quota_inum);
> 	sb->s_usr_quota_inum = ext2fs_swab32(sb->s_usr_quota_inum);
> 	sb->s_grp_quota_inum = ext2fs_swab32(sb->s_grp_quota_inum);
> 	sb->s_overhead_blocks = ext2fs_swab32(sb->s_overhead_blocks);


Cheers, Andreas

Patch

diff --git a/lib/ext2fs/swapfs.c b/lib/ext2fs/swapfs.c
index b7c01005..60cdf124 100644
--- a/lib/ext2fs/swapfs.c
+++ b/lib/ext2fs/swapfs.c
@@ -81,6 +81,7 @@  void ext2fs_swap_super(struct ext2_super_block * sb)
 	sb->s_snapshot_r_blocks_count =
 		ext2fs_swab64(sb->s_snapshot_r_blocks_count);
 	sb->s_snapshot_list = ext2fs_swab32(sb->s_snapshot_list);
+	sb->s_prj_quota_inum = ext2fs_swab32(sb->s_prj_quota_inum);
 	sb->s_usr_quota_inum = ext2fs_swab32(sb->s_usr_quota_inum);
 	sb->s_grp_quota_inum = ext2fs_swab32(sb->s_grp_quota_inum);
 	sb->s_overhead_blocks = ext2fs_swab32(sb->s_overhead_blocks);