| Message ID | 20171114052343.18808-1-andrew@aj.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [linux,dev-4.10] aspeed: dts: Update some platforms to mux RMII1 for MAC0 | expand |
Acked-by: Mykola Kostenok <c_mykolak@mellanox.com> Best regards. Mykola Kostenok. > -----Original Message----- > From: Andrew Jeffery [mailto:andrew@aj.id.au] > Sent: Tuesday, November 14, 2017 7:24 AM > To: joel@jms.id.au > Cc: Andrew Jeffery <andrew@aj.id.au>; openbmc@lists.ozlabs.org; Mykola > Kostenok <c_mykolak@mellanox.com>; Patrick Venture > <venture@google.com> > Subject: [PATCH linux dev-4.10] aspeed: dts: Update some platforms to mux > RMII1 for MAC0 > > I noticed that Witherspoon was missing its pinctrl properties for the mac0 > node. On auditing the rest of the DTS files, the MSN and Q71L platforms > appeared to have the same issue. > > Add the pinctrl nodes to ensure MAC0 has RMII1 muxed. This provides > mutual exclusion with the GPIO subsystem ensuring broken userspace can't > interfere with networking. > > Cc: Mykola Kostenok <c_mykolak@mellanox.com> > Cc: Patrick Venture <venture@google.com> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts | 3 +++ > arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 +++ > arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts > b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts > index d1dc2ef1a162..1005d6becdba 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts > @@ -48,6 +48,9 @@ > &mac0 { > status = "okay"; > use-ncsi; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > }; > > &i2c5 { > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > index 68058eca1559..cc1fd0dc6677 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts > @@ -239,6 +239,9 @@ > > use-ncsi; > no-hw-checksum; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > }; > > &i2c0 { > diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts > b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts > index 7ed3a773b2d5..41368734f07d 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts > @@ -139,6 +139,9 @@ > > use-ncsi; > no-hw-checksum; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > }; > > &mac1 { > -- > 2.14.1
diff --git a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts index d1dc2ef1a162..1005d6becdba 100644 --- a/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts +++ b/arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts @@ -48,6 +48,9 @@ &mac0 { status = "okay"; use-ncsi; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; }; &i2c5 { diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts index 68058eca1559..cc1fd0dc6677 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts @@ -239,6 +239,9 @@ use-ncsi; no-hw-checksum; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; }; &i2c0 { diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts index 7ed3a773b2d5..41368734f07d 100644 --- a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts +++ b/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts @@ -139,6 +139,9 @@ use-ncsi; no-hw-checksum; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii1_default>; }; &mac1 {
I noticed that Witherspoon was missing its pinctrl properties for the mac0 node. On auditing the rest of the DTS files, the MSN and Q71L platforms appeared to have the same issue. Add the pinctrl nodes to ensure MAC0 has RMII1 muxed. This provides mutual exclusion with the GPIO subsystem ensuring broken userspace can't interfere with networking. Cc: Mykola Kostenok <c_mykolak@mellanox.com> Cc: Patrick Venture <venture@google.com> Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts | 3 +++ arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 +++ arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 3 +++ 3 files changed, 9 insertions(+)