[ovs-dev] ovn.at: Fix MSYS IPv6 interpretation

Message ID 20171114014944.22224-1-aserdean@ovn.org
State New
Headers show
Series
  • [ovs-dev] ovn.at: Fix MSYS IPv6 interpretation
Related show

Commit Message

Alin Gabriel Serdean Nov. 14, 2017, 1:49 a.m.
Unfortunately MSYS transforms `0::` into the location of the binaries i.e.:
c:\MinGW\msys\1.0\64.

Currently the test:
`testing ovn -- IPv6 Neighbor Solicitation for unknown MAC`
fails because of the above:
"ovn-nbctl: lrp0_ip6: invalid network address: aef0;c:\MinGW\msys\1.0\64"

This patch uses the full form of the IPv6 address instead of its shorter
notation.

Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
---
 tests/ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Pfaff Nov. 14, 2017, 6:16 p.m. | #1
On Tue, Nov 14, 2017 at 03:49:44AM +0200, Alin Gabriel Serdean wrote:
> Unfortunately MSYS transforms `0::` into the location of the binaries i.e.:
> c:\MinGW\msys\1.0\64.
> 
> Currently the test:
> `testing ovn -- IPv6 Neighbor Solicitation for unknown MAC`
> fails because of the above:
> "ovn-nbctl: lrp0_ip6: invalid network address: aef0;c:\MinGW\msys\1.0\64"
> 
> This patch uses the full form of the IPv6 address instead of its shorter
> notation.
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
> ---
>  tests/ovn.at | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ovn.at b/tests/ovn.at
> index f051d86..b6a83cc 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -8877,7 +8877,7 @@ ovn-nbctl lsp-set-port-security sw0_ip6-port1 \
>  "50:64:00:00:00:02 aef0::5264:00ff:fe00:0002"
>  
>  ovn-nbctl lr-add lr0_ip6
> -ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01 aef0::/64
> +ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01 aef0:0:0:0:0:0:0:0/64

That's actually kind of funny.

Acked-by: Ben Pfaff <blp@ovn.org>
Alin Gabriel Serdean Nov. 14, 2017, 6:43 p.m. | #2
> -----Original Message-----
> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-
> bounces@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Tuesday, November 14, 2017 8:16 PM
> To: Alin Gabriel Serdean <aserdean@ovn.org>
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] ovn.at: Fix MSYS IPv6 interpretation
> 
> On Tue, Nov 14, 2017 at 03:49:44AM +0200, Alin Gabriel Serdean wrote:
> > Unfortunately MSYS transforms `0::` into the location of the binaries i.e.:
> > c:\MinGW\msys\1.0\64.
> >
> > Currently the test:
> > `testing ovn -- IPv6 Neighbor Solicitation for unknown MAC` fails
> > because of the above:
> > "ovn-nbctl: lrp0_ip6: invalid network address:
> aef0;c:\MinGW\msys\1.0\64"
> >
> > This patch uses the full form of the IPv6 address instead of its
> > shorter notation.
> >
> > Signed-off-by: Alin Gabriel Serdean <aserdean@ovn.org>
> > ---
> >  tests/ovn.at | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/ovn.at b/tests/ovn.at index f051d86..b6a83cc 100644
> > --- a/tests/ovn.at
> > +++ b/tests/ovn.at
> > @@ -8877,7 +8877,7 @@ ovn-nbctl lsp-set-port-security sw0_ip6-port1 \
> >  "50:64:00:00:00:02 aef0::5264:00ff:fe00:0002"
> >
> >  ovn-nbctl lr-add lr0_ip6
> > -ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01 aef0::/64
> > +ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01
> > +aef0:0:0:0:0:0:0:0/64
> 
> That's actually kind of funny.
> 
> Acked-by: Ben Pfaff <blp@ovn.org>
It has its moments 😊.
Thanks for the quick review. I applied on master.

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index f051d86..b6a83cc 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -8877,7 +8877,7 @@  ovn-nbctl lsp-set-port-security sw0_ip6-port1 \
 "50:64:00:00:00:02 aef0::5264:00ff:fe00:0002"
 
 ovn-nbctl lr-add lr0_ip6
-ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01 aef0::/64
+ovn-nbctl lrp-add lr0_ip6 lrp0_ip6 00:00:00:00:af:01 aef0:0:0:0:0:0:0:0/64
 ovn-nbctl lsp-add sw0_ip6 lrp0_ip6-attachment
 ovn-nbctl lsp-set-type lrp0_ip6-attachment router
 ovn-nbctl lsp-set-addresses lrp0_ip6-attachment 00:00:00:00:af:01