[U-Boot] mmc: sh_mmcif: RZ/A1 does not support HS mode

Message ID 20171113204139.5841-1-chris.brandt@renesas.com
State Rejected
Delegated to: Jaehoon Chung
Headers show
Series
  • [U-Boot] mmc: sh_mmcif: RZ/A1 does not support HS mode
Related show

Commit Message

Chris Brandt Nov. 13, 2017, 8:41 p.m.
Since RZ/A1 (R7S72100) does not support HS mode, remove it from the
host caps.

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 drivers/mmc/sh_mmcif.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jaehoon Chung Nov. 27, 2017, 7:38 a.m. | #1
On 11/14/2017 05:41 AM, Chris Brandt wrote:
> Since RZ/A1 (R7S72100) does not support HS mode, remove it from the
> host caps.

Doesn't HS mode? Then it's only supported the legacy mode?

> 
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
>  drivers/mmc/sh_mmcif.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c
> index 1ff59f06d5..4b62795044 100644
> --- a/drivers/mmc/sh_mmcif.c
> +++ b/drivers/mmc/sh_mmcif.c
> @@ -576,8 +576,12 @@ static const struct mmc_ops sh_mmcif_ops = {
>  static struct mmc_config sh_mmcif_cfg = {
>  	.name		= DRIVER_NAME,
>  	.ops		= &sh_mmcif_ops,
> +#if defined(CONFIG_R7S72100)
> +	.host_caps	= MMC_MODE_4BIT | MMC_MODE_8BIT,
> +#else
>  	.host_caps	= MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT |
>  			  MMC_MODE_8BIT,
> +#endif
>  	.voltages	= MMC_VDD_32_33 | MMC_VDD_33_34,
>  	.b_max		= CONFIG_SYS_MMC_MAX_BLK_COUNT,
>  };
>
Chris Brandt Nov. 27, 2017, 12:02 p.m. | #2
On Monday, November 27, 2017, Jaehoon Chung wrote:
> On 11/14/2017 05:41 AM, Chris Brandt wrote:

> > Since RZ/A1 (R7S72100) does not support HS mode, remove it from the

> > host caps.

> 

> Doesn't HS mode? Then it's only supported the legacy mode?


Sorry, please ignore this patch.

The MMC controller in the RZ/A1 can generate up to a 33MHz clock, so it 
does support "High Speed" mode.

I just tested it and it works fine the way it is.


Chris

Patch

diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c
index 1ff59f06d5..4b62795044 100644
--- a/drivers/mmc/sh_mmcif.c
+++ b/drivers/mmc/sh_mmcif.c
@@ -576,8 +576,12 @@  static const struct mmc_ops sh_mmcif_ops = {
 static struct mmc_config sh_mmcif_cfg = {
 	.name		= DRIVER_NAME,
 	.ops		= &sh_mmcif_ops,
+#if defined(CONFIG_R7S72100)
+	.host_caps	= MMC_MODE_4BIT | MMC_MODE_8BIT,
+#else
 	.host_caps	= MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT |
 			  MMC_MODE_8BIT,
+#endif
 	.voltages	= MMC_VDD_32_33 | MMC_VDD_33_34,
 	.b_max		= CONFIG_SYS_MMC_MAX_BLK_COUNT,
 };