diff mbox series

[linux-oem] ALSA: hda - fix headset mic problem for Dell machines with alc274

Message ID 1510545660-7730-1-git-send-email-hui.wang@canonical.com
State New
Headers show
Series [linux-oem] ALSA: hda - fix headset mic problem for Dell machines with alc274 | expand

Commit Message

Hui Wang Nov. 13, 2017, 4:01 a.m. UTC 
BugLink: http://bugs.launchpad.net/bugs/1731822

Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
the pin 0x1a is for Headphone Mic, he suggested to apply
ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
verified applying this FIXUP can fix this problem.

Cc: <stable@vger.kernel.org>
Cc: Kailang Yang <kailang@realtek.com>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stefan Bader Nov. 15, 2017, 1:38 p.m. UTC | #1 
On 13.11.2017 05:01, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822

The linked bug report is not really sru policy complete

-Stefan

> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 217bb58..ba48ffa 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
>
Hui Wang Nov. 16, 2017, 12:57 a.m. UTC | #2 
On 2017年11月15日 21:38, Stefan Bader wrote:
> On 13.11.2017 05:01, Hui Wang wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1731822
> The linked bug report is not really sru policy complete
Added more description to the bug report.

Thanks.

>
> -Stefan
>
>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>> the pin 0x1a is for Headphone Mic, he suggested to apply
>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>> verified applying this FIXUP can fix this problem.
>>
>> Cc: <stable@vger.kernel.org>
>> Cc: Kailang Yang <kailang@realtek.com>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>>   sound/pci/hda/patch_realtek.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 217bb58..ba48ffa 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>>   		{0x14, 0x90170110},
>>   		{0x1b, 0x90a70130},
>>   		{0x21, 0x03211020}),
>> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>> +		{0x12, 0xb7a60130},
>> +		{0x13, 0xb8a61140},
>> +		{0x16, 0x90170110},
>> +		{0x21, 0x04211020}),
>>   	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>   		{0x12, 0x90a60130},
>>   		{0x14, 0x90170110},
>>
>
Stefan Bader Nov. 17, 2017, 2:36 p.m. UTC | #3 
On 16.11.2017 01:57, Hui Wang wrote:
> On 2017年11月15日 21:38, Stefan Bader wrote:
>> On 13.11.2017 05:01, Hui Wang wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1731822
>> The linked bug report is not really sru policy complete
> Added more description to the bug report.

I was trying to point out the missing

===

SRU Justification:

Impact:

Fix:

Testcase:

Regression risk:

===

template stuff. In the end it is Timo's call how anally he wants to follow the
normal SRU procedure. But on the other hand making all the same is easier to
remember. :)

-Stefan

> 
> Thanks.
> 
>>
>> -Stefan
>>
>>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>>> the pin 0x1a is for Headphone Mic, he suggested to apply
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>>> verified applying this FIXUP can fix this problem.
>>>
>>> Cc: <stable@vger.kernel.org>
>>> Cc: Kailang Yang <kailang@realtek.com>
>>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>>> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>>> ---
>>>   sound/pci/hda/patch_realtek.c | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>> index 217bb58..ba48ffa 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk
>>> alc269_pin_fixup_tbl[] = {
>>>           {0x14, 0x90170110},
>>>           {0x1b, 0x90a70130},
>>>           {0x21, 0x03211020}),
>>> +    SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell",
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>>> +        {0x12, 0xb7a60130},
>>> +        {0x13, 0xb8a61140},
>>> +        {0x16, 0x90170110},
>>> +        {0x21, 0x04211020}),
>>>       SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>>           {0x12, 0x90a60130},
>>>           {0x14, 0x90170110},
>>>
>>
>
Hui Wang Nov. 18, 2017, 12:32 a.m. UTC | #4 
On 2017年11月17日 22:36, Stefan Bader wrote:
> On 16.11.2017 01:57, Hui Wang wrote:
>> On 2017年11月15日 21:38, Stefan Bader wrote:
>>> On 13.11.2017 05:01, Hui Wang wrote:
>>>> BugLink: http://bugs.launchpad.net/bugs/1731822
>>> The linked bug report is not really sru policy complete
>> Added more description to the bug report.
> I was trying to point out the missing
>
> ===
>
> SRU Justification:
>
> Impact:
>
> Fix:
>
> Testcase:
>
> Regression risk:
>
> ===
>
> template stuff. In the end it is Timo's call how anally he wants to follow the
> normal SRU procedure. But on the other hand making all the same is easier to
> remember. :)
>
> -Stefan
OK, got it. thank you.

>
>> Thanks.
>>
>>> -Stefan
>>>
>>>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>>>> the pin 0x1a is for Headphone Mic, he suggested to apply
>>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>>>> verified applying this FIXUP can fix this problem.
>>>>
>>>> Cc: <stable@vger.kernel.org>
>>>> Cc: Kailang Yang <kailang@realtek.com>
>>>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>>>> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>>>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>>>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>>>> ---
>>>>    sound/pci/hda/patch_realtek.c | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>>> index 217bb58..ba48ffa 100644
>>>> --- a/sound/pci/hda/patch_realtek.c
>>>> +++ b/sound/pci/hda/patch_realtek.c
>>>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk
>>>> alc269_pin_fixup_tbl[] = {
>>>>            {0x14, 0x90170110},
>>>>            {0x1b, 0x90a70130},
>>>>            {0x21, 0x03211020}),
>>>> +    SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell",
>>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>>>> +        {0x12, 0xb7a60130},
>>>> +        {0x13, 0xb8a61140},
>>>> +        {0x16, 0x90170110},
>>>> +        {0x21, 0x04211020}),
>>>>        SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>>>            {0x12, 0x90a60130},
>>>>            {0x14, 0x90170110},
>>>>
>
Stefan Bader Nov. 20, 2017, 3:34 p.m. UTC | #5 
On 13.11.2017 05:01, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>

> ---

Looks sensible to me. Note that I think the bug should have been filed against
linux-oem (I changed that) and with a xenial task (probably should have
nominated before flipping the package...

-Stefan
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 217bb58..ba48ffa 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
>
Colin Ian King Jan. 23, 2018, 1:54 p.m. UTC | #6 
On 13/11/17 04:01, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822
> 
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
> 
> Cc: <stable@vger.kernel.org>
> Cc: Kailang Yang <kailang@realtek.com>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 217bb58..ba48ffa 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x14, 0x90170110},
>  		{0x1b, 0x90a70130},
>  		{0x21, 0x03211020}),
> +	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0xb7a60130},
> +		{0x13, 0xb8a61140},
> +		{0x16, 0x90170110},
> +		{0x21, 0x04211020}),
>  	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>  		{0x12, 0x90a60130},
>  		{0x14, 0x90170110},
> 

Reasonable quirk, affects limited H/W, so..

Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 217bb58..ba48ffa 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6510,6 +6510,11 @@  static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x14, 0x90170110},
 		{0x1b, 0x90a70130},
 		{0x21, 0x03211020}),
+	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
+		{0x12, 0xb7a60130},
+		{0x13, 0xb8a61140},
+		{0x16, 0x90170110},
+		{0x21, 0x04211020}),
 	SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
 		{0x12, 0x90a60130},
 		{0x14, 0x90170110},