diff mbox series

[2/2] package/ffmpeg: fix fenv build failure on ARCv2 with glibc

Message ID 20171111162242.15110-2-bernd.kuhls@t-online.de
State Accepted
Headers show
Series [1/2] package/ffmpeg: simplify BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS logic | expand

Commit Message

Bernd Kuhls Nov. 11, 2017, 4:22 p.m. UTC
https://git.buildroot.net/buildroot/commit/toolchain?id=0633eb58a2912328508a76f8fe9875a0d113a880
added glibc support for ARCv2 which lacks fenv.h.

Code format was suggested by Arnout:
http://lists.busybox.net/pipermail/buildroot/2017-November/206631.html

Fixes
http://autobuild.buildroot.net/results/aec/aec300d7d4472421398a24202d6871c965bd1be5/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/ffmpeg/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Nov. 11, 2017, 10:22 p.m. UTC | #1
Hello,

On Sat, 11 Nov 2017 17:22:42 +0100, Bernd Kuhls wrote:

> +	# fenv.h lacks FE_INVALID, FE_OVERFLOW & FE_UNDERFLOW
> +	depends on !BR2_archs38 || !BR2_TOOLCHAIN_USES_GLIBC

I've changed this to:

	depends on !(BR2_archs38 && BR2_TOOLCHAIN_USES_GLIBC)

which IMO is easier to read as it match the human way of expressingthe
dependency: "not available on ARC HS38 with glibc".

Applied with this change. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/ffmpeg/Config.in b/package/ffmpeg/Config.in
index 17a4881348..1b0e71a836 100644
--- a/package/ffmpeg/Config.in
+++ b/package/ffmpeg/Config.in
@@ -1,6 +1,8 @@ 
 config BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
 	bool
 	default y
+	# fenv.h lacks FE_INVALID, FE_OVERFLOW & FE_UNDERFLOW
+	depends on !BR2_archs38 || !BR2_TOOLCHAIN_USES_GLIBC
 	# fenv.h lacks FE_INVALID, FE_OVERFLOW & FE_UNDERFLOW on nios2
 	depends on !BR2_nios
 	# No support for ARMv7-M in the ARM assembly logic