[e2fsprogs] tests: Fixup for new r_move_itable tests.

Message ID 20171111075540.21722-1-mbakke@fastmail.com
State New
Headers show
Series
  • [e2fsprogs] tests: Fixup for new r_move_itable tests.
Related show

Commit Message

Marius Bakke Nov. 11, 2017, 7:55 a.m.
Commits 257f009d1034737096f197dc875931207bcdfc75 and
2b50c18a8a12781c26b71873f4368fe61711d9f9 missed one pass in expected
output.

Signed-off-by: Marius Bakke <mbakke@fastmail.com>
---
 tests/r_move_itable_nostride/expect | 2 ++
 tests/r_move_itable_realloc/expect  | 2 ++
 2 files changed, 4 insertions(+)

Comments

Theodore Y. Ts'o Jan. 11, 2018, 7:13 p.m. | #1
On Sat, Nov 11, 2017 at 08:55:40AM +0100, Marius Bakke wrote:
> Commits 257f009d1034737096f197dc875931207bcdfc75 and
> 2b50c18a8a12781c26b71873f4368fe61711d9f9 missed one pass in expected
> output.
> 
> Signed-off-by: Marius Bakke <mbakke@fastmail.com>

Hi, what architecture did you discover this on?  I don't need this
change on x86, but I was seeing some mysterious regression test
failures on a big-endian system which seemed to look like this.  I
didn't have time to follow up on it then, but I suspect that this may
be what you are running into.

Can you confirm?

Thanks,

						- Ted
Marius Bakke Jan. 13, 2018, 5:37 a.m. | #2
Theodore Ts'o <tytso@mit.edu> writes:

> On Sat, Nov 11, 2017 at 08:55:40AM +0100, Marius Bakke wrote:
>> Commits 257f009d1034737096f197dc875931207bcdfc75 and
>> 2b50c18a8a12781c26b71873f4368fe61711d9f9 missed one pass in expected
>> output.
>> 
>> Signed-off-by: Marius Bakke <mbakke@fastmail.com>
>
> Hi, what architecture did you discover this on?  I don't need this
> change on x86, but I was seeing some mysterious regression test
> failures on a big-endian system which seemed to look like this.  I
> didn't have time to follow up on it then, but I suspect that this may
> be what you are running into.

Thanks for the reply.  I get this on x86, but upon further
investigation, it only happens in the Guix build container.

Running "make check" interactively in a terminal works.  Do you have any
idea what may cause these two tests to extend the inode table when run
in the isolated build chroot?

Patch

diff --git a/tests/r_move_itable_nostride/expect b/tests/r_move_itable_nostride/expect
index 098cbfc5..4976e65e 100644
--- a/tests/r_move_itable_nostride/expect
+++ b/tests/r_move_itable_nostride/expect
@@ -1,6 +1,8 @@ 
 mke2fs -q -F -o Linux -b 1024 -i 1024 -E stride=8192 -t ext4 test.img 1024000
 resize2fs -p test.img 10240000
 Resizing the filesystem on test.img to 100000000 (1k) blocks.
+Begin pass 1 (max = 12082)
+Extending the inode table     ----------------------------------------XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
 Begin pass 2 (max = 2062)
 Relocating blocks             ----------------------------------------XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
 Begin pass 3 (max = 125)
diff --git a/tests/r_move_itable_realloc/expect b/tests/r_move_itable_realloc/expect
index 73b2fef0..1312d954 100644
--- a/tests/r_move_itable_realloc/expect
+++ b/tests/r_move_itable_realloc/expect
@@ -1,6 +1,8 @@ 
 mke2fs -q -F -o Linux -b 1024 -i 1024 -O ^resize_inode -t ext4 test.img 1024000
 resize2fs -p test.img 10240000
 Resizing the filesystem on test.img to 100000000 (1k) blocks.
+Begin pass 1 (max = 12082)
+Extending the inode table     ----------------------------------------XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
 Begin pass 2 (max = 2061)
 Relocating blocks             ----------------------------------------XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
 Begin pass 3 (max = 125)