From patchwork Sat Nov 11 01:45:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 836984 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="YzmKh7n6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YzmKh7n6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yYfqm6ZwHz9sPt for ; Sat, 11 Nov 2017 12:45:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753541AbdKKBpj (ORCPT ); Fri, 10 Nov 2017 20:45:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60414 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdKKBpi (ORCPT ); Fri, 10 Nov 2017 20:45:38 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DFCDE607F5; Sat, 11 Nov 2017 01:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1510364737; bh=BkCFxjNiYbzPN9wqWJFGpE0tZx8iB6vQV3M8KdT0Dxg=; h=From:To:Cc:Subject:Date:From; b=YzmKh7n6HfjZBW1iXK/Chw2HblBO6ZKCvk+A+XWsv88EN/FQ/Z09io8m5SB5w+0Dt xB8rGNU8BJXmCHDq6UZszeBuB4j9gxzEhLOpFl8m7ivM1QmE9feQjdpElD5CbldxDL fFK9sdJzmydnkmSwLt5N92BgauizUVB9Jz9DGQSY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from sboyd-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 32F9F60600; Sat, 11 Nov 2017 01:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1510364737; bh=BkCFxjNiYbzPN9wqWJFGpE0tZx8iB6vQV3M8KdT0Dxg=; h=From:To:Cc:Subject:Date:From; b=YzmKh7n6HfjZBW1iXK/Chw2HblBO6ZKCvk+A+XWsv88EN/FQ/Z09io8m5SB5w+0Dt xB8rGNU8BJXmCHDq6UZszeBuB4j9gxzEhLOpFl8m7ivM1QmE9feQjdpElD5CbldxDL fFK9sdJzmydnkmSwLt5N92BgauizUVB9Jz9DGQSY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 32F9F60600 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org From: Stephen Boyd To: Rob Herring , Frank Rowand Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH] of: Document exactly what of_find_node_by_name() puts Date: Fri, 10 Nov 2017 17:45:36 -0800 Message-Id: <20171111014536.3592-1-sboyd@codeaurora.org> X-Mailer: git-send-email 2.15.0.124.g7668cbc60578 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org It isn't clear if this function of_node_put()s the 'from' argument, or the node it finds in the search. Clearly indicate which variable is touched. Signed-off-by: Stephen Boyd --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 63897531cd75..602c5d65734a 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path); * @from: The node to start searching from or NULL, the node * you pass will not be searched, only the next one * will; typically, you pass what the previous call - * returned. of_node_put() will be called on it + * returned. of_node_put() will be called on @from. * @name: The name string to match against * * Returns a node pointer with refcount incremented, use