| Message ID | 20171110183358.86100-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] i2c: ismt: Use %pad specifier for dma_addr_t variables | expand |
On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote: > ...which takes care of proper format and size of the value. Wolfram, any comment on this? > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/i2c/busses/i2c-ismt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c- > ismt.c > index b51adffa4841..c0d0f34d34f3 100644 > --- a/drivers/i2c/busses/i2c-ismt.c > +++ b/drivers/i2c/busses/i2c-ismt.c > @@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap, > u16 addr, > return -EIO; > } > > - dev_dbg(dev, " dma_addr = 0x%016llX\n", > - (unsigned long long)dma_addr); > + dev_dbg(dev, " dma_addr = %pad\n", &dma_addr); > > desc->dptr_low = lower_32_bits(dma_addr); > desc->dptr_high = upper_32_bits(dma_addr);
On Thu, Dec 28, 2017 at 05:21:51PM +0200, Andy Shevchenko wrote: > On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote: > > ...which takes care of proper format and size of the value. > > Wolfram, any comment on this? I was leaving this for the driver maintainers, but well, this is an easy one, so... > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied to for-next, thanks!
On Sun, Dec 31, 2017 at 12:22:01AM +0100, Wolfram Sang wrote: > On Thu, Dec 28, 2017 at 05:21:51PM +0200, Andy Shevchenko wrote: > > On Fri, 2017-11-10 at 20:33 +0200, Andy Shevchenko wrote: > > > ...which takes care of proper format and size of the value. > > > > Wolfram, any comment on this? > > I was leaving this for the driver maintainers, but well, this is an easy > one, so... > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Applied to for-next, thanks! > Sorry for the delay, I was on holiday. FWIW Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Sorry for the delay, I was on holiday. FWIW > Acked-by: Neil Horman <nhorman@tuxdriver.com> Ah, nice you are back, hopefully relaxed ;) There are two more ismt patches pending: http://patchwork.ozlabs.org/project/linux-i2c/list/?series=&submitter=&state=&q=ismt&archive=&delegate= Could you check them?
On Wed, Jan 03, 2018 at 11:00:25PM +0100, Wolfram Sang wrote: > > > Sorry for the delay, I was on holiday. FWIW > > Acked-by: Neil Horman <nhorman@tuxdriver.com> > > Ah, nice you are back, hopefully relaxed ;) > > There are two more ismt patches pending: > > http://patchwork.ozlabs.org/project/linux-i2c/list/?series=&submitter=&state=&q=ismt&archive=&delegate= > > Could you check them? > will take care of it in the am Neil
diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c index b51adffa4841..c0d0f34d34f3 100644 --- a/drivers/i2c/busses/i2c-ismt.c +++ b/drivers/i2c/busses/i2c-ismt.c @@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr, return -EIO; } - dev_dbg(dev, " dma_addr = 0x%016llX\n", - (unsigned long long)dma_addr); + dev_dbg(dev, " dma_addr = %pad\n", &dma_addr); desc->dptr_low = lower_32_bits(dma_addr); desc->dptr_high = upper_32_bits(dma_addr);
...which takes care of proper format and size of the value. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-ismt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)