[1/3] Documentation : can : flexcan : Add big-endian property to device tree

Message ID 1510309043-16777-1-git-send-email-pankaj.bansal@nxp.com
State Rejected
Headers show
Series
  • [1/3] Documentation : can : flexcan : Add big-endian property to device tree
Related show

Commit Message

Pankaj Bansal Nov. 10, 2017, 10:17 a.m.
The FlexCAN controller can be modelled as little or big endian
depending on SOC design. This device tree property identifies the
controller endianness and the driver reads/writes controller registers
based on that.

This is optional property. i.e. if this property is not present in
device tree node then controller is assumed to be little endian. if
this property is present then controller is assumed to be big endian.

Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
Reviewed-by: Poonam Aggrwal <poonam.aggrwal@nxp.com>
---
 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Marc Kleine-Budde Nov. 10, 2017, 10:36 a.m. | #1
On 11/10/2017 11:17 AM, Pankaj Bansal wrote:
> The FlexCAN controller can be modelled as little or big endian
> depending on SOC design. This device tree property identifies the
> controller endianness and the driver reads/writes controller registers
> based on that.
> 
> This is optional property. i.e. if this property is not present in
> device tree node then controller is assumed to be little endian. if
> this property is present then controller is assumed to be big endian.
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal@nxp.com>
> Reviewed-by: Poonam Aggrwal <poonam.aggrwal@nxp.com>

NACK, this is not backwards compatible.

See mail on linux-can for better solution.

Marc

> ---
>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 56d6cc3..b9693c7 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -18,6 +18,8 @@ Optional properties:
>  
>  - xceiver-supply: Regulator that powers the CAN transceiver
>  
> +- big-endian: This means the registers of FlexCAN controller are big endian
> +
>  Example:
>  
>  	can@1c000 {
> @@ -26,4 +28,5 @@ Example:
>  		interrupts = <48 0x2>;
>  		interrupt-parent = <&mpic>;
>  		clock-frequency = <200000000>; // filled in by bootloader
> +		big-endian;
>  	};
>

Patch

diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
index 56d6cc3..b9693c7 100644
--- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
+++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
@@ -18,6 +18,8 @@  Optional properties:
 
 - xceiver-supply: Regulator that powers the CAN transceiver
 
+- big-endian: This means the registers of FlexCAN controller are big endian
+
 Example:
 
 	can@1c000 {
@@ -26,4 +28,5 @@  Example:
 		interrupts = <48 0x2>;
 		interrupt-parent = <&mpic>;
 		clock-frequency = <200000000>; // filled in by bootloader
+		big-endian;
 	};