[1/6] dt-bindings: usb: add #phy-cells to usb-nop-xceiv

Message ID 20171109222614.5719-1-robh@kernel.org
State Accepted
Headers show
Series
  • [1/6] dt-bindings: usb: add #phy-cells to usb-nop-xceiv
Related show

Commit Message

Rob Herring Nov. 9, 2017, 10:26 p.m.
Consumers of usb-nop-xceiv use the phy binding, but #phy-cells is missing
from the binding. This is probably because this binding predates the
common phy binding. So add #phy-cells as a required property. This should
not break any users as missing should be treated as 0 cells.

Signed-off-by: Rob Herring <robh@kernel.org>
---
I'll apply to DT tree.

 Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tony Lindgren Nov. 10, 2017, 4:25 p.m. | #1
* Rob Herring <robh@kernel.org> [171109 14:28]:
> "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> property. This is probably because the binding was the precursor to the phy
> binding.
> 
> Fixes the following warning in OMAP dts files:
> 
> Warning (phys_property): Missing property '#phy-cells' in node ...
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: "BenoƮt Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Enric Balletbo i Serra <eballetbo@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: linux-omap@vger.kernel.org
> ---
> Please apply to TI tree.

Thanks applying into omap-for-v4.15/fixes-dt.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shawn Guo Nov. 16, 2017, 11:10 a.m. | #2
On Thu, Nov 09, 2017 at 04:26:10PM -0600, Rob Herring wrote:
> "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> property. This is probably because the binding was the precursor to the phy
> binding.
> 
> Fixes the following warning in i.MX dts files:
> 
> Warning (phys_property): Missing property '#phy-cells' in node ...
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Nov. 21, 2017, 6:29 p.m. | #3
On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
> "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> property. This is probably because the binding was the precursor to the phy
> binding.
>
> Fixes the following warning in Marvell dts files:
>
> Warning (phys_property): Missing property '#phy-cells' in node ...
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Please apply to Marvell tree.

Ping.

Arnd, can you apply if you'd like the warnings fixed and Marvell
maintainers don't respond.

>
>  arch/arm/boot/dts/armada-385-db-ap.dts          | 1 +
>  arch/arm/boot/dts/armada-385-linksys.dtsi       | 1 +
>  arch/arm/boot/dts/armada-385-synology-ds116.dts | 2 ++
>  arch/arm/boot/dts/armada-388-gp.dts             | 2 ++
>  4 files changed, 6 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andrew Lunn Nov. 21, 2017, 8:09 p.m. | #4
On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> > property. This is probably because the binding was the precursor to the phy
> > binding.
> >
> > Fixes the following warning in Marvell dts files:
> >
> > Warning (phys_property): Missing property '#phy-cells' in node ...
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> > ---
> > Please apply to Marvell tree.
> 
> Ping.
> 
> Arnd, can you apply if you'd like the warnings fixed and Marvell
> maintainers don't respond.

Hi Rob

Patches submitted a week before the merge window opens are generally
deferred to the next cycle. I expect that once -rc1 is out, Gregory
will pick up this patch.

     Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnd Bergmann Nov. 21, 2017, 8:45 p.m. | #5
On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>> > property. This is probably because the binding was the precursor to the phy
>> > binding.
>> >
>> > Fixes the following warning in Marvell dts files:
>> >
>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>> >
>> > Signed-off-by: Rob Herring <robh@kernel.org>
>> > Cc: Jason Cooper <jason@lakedaemon.net>
>> > Cc: Andrew Lunn <andrew@lunn.ch>
>> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> > ---
>> > Please apply to Marvell tree.
>>
>> Ping.
>>
>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>> maintainers don't respond.
>
> Hi Rob
>
> Patches submitted a week before the merge window opens are generally
> deferred to the next cycle. I expect that once -rc1 is out, Gregory
> will pick up this patch.

These are real bugfixes, I want them in 4.15, since we now get a
loud warning for them. I'd rather not shut up that warning because
it's not a false-positive.

       Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andrew Lunn Nov. 21, 2017, 8:56 p.m. | #6
On Thu, Nov 09, 2017 at 04:26:11PM -0600, Rob Herring wrote:
> "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> property. This is probably because the binding was the precursor to the phy
> binding.
> 
> Fixes the following warning in Marvell dts files:
> 
> Warning (phys_property): Missing property '#phy-cells' in node ...
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gregory CLEMENT Nov. 22, 2017, 4:59 p.m. | #7
Hi Arnd,
 
 On mar., nov. 21 2017, Arnd Bergmann <arnd@arndb.de> wrote:

> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>>> > property. This is probably because the binding was the precursor to the phy
>>> > binding.
>>> >
>>> > Fixes the following warning in Marvell dts files:
>>> >
>>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>>> >
>>> > Signed-off-by: Rob Herring <robh@kernel.org>
>>> > Cc: Jason Cooper <jason@lakedaemon.net>
>>> > Cc: Andrew Lunn <andrew@lunn.ch>
>>> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>> > ---
>>> > Please apply to Marvell tree.
>>>
>>> Ping.
>>>
>>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>>> maintainers don't respond.
>>
>> Hi Rob
>>
>> Patches submitted a week before the merge window opens are generally
>> deferred to the next cycle. I expect that once -rc1 is out, Gregory
>> will pick up this patch.
>
> These are real bugfixes, I want them in 4.15, since we now get a
> loud warning for them. I'd rather not shut up that warning because
> it's not a false-positive.

As pointed by Andrew, I planned to take them once the 4.15-rc1 would be
released. It was not obvious for me that it was real fixes. Actually I
would have expected to have first the dts fixed in a release and then
the warning enabled.

I am fine if you take this patch, especially if it is merged in
4.15-rc1.

So for this patch:

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory


>
>        Arnd
Rob Herring Nov. 28, 2017, 7:38 p.m. | #8
On Wed, Nov 22, 2017 at 10:59 AM, Gregory CLEMENT
<gregory.clement@free-electrons.com> wrote:
> Hi Arnd,
>
>  On mar., nov. 21 2017, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> On Tue, Nov 21, 2017 at 9:09 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>>> On Tue, Nov 21, 2017 at 12:29:48PM -0600, Rob Herring wrote:
>>>> On Thu, Nov 9, 2017 at 4:26 PM, Rob Herring <robh@kernel.org> wrote:
>>>> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
>>>> > property. This is probably because the binding was the precursor to the phy
>>>> > binding.
>>>> >
>>>> > Fixes the following warning in Marvell dts files:
>>>> >
>>>> > Warning (phys_property): Missing property '#phy-cells' in node ...
>>>> >
>>>> > Signed-off-by: Rob Herring <robh@kernel.org>
>>>> > Cc: Jason Cooper <jason@lakedaemon.net>
>>>> > Cc: Andrew Lunn <andrew@lunn.ch>
>>>> > Cc: Gregory Clement <gregory.clement@free-electrons.com>
>>>> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>>>> > ---
>>>> > Please apply to Marvell tree.
>>>>
>>>> Ping.
>>>>
>>>> Arnd, can you apply if you'd like the warnings fixed and Marvell
>>>> maintainers don't respond.
>>>
>>> Hi Rob
>>>
>>> Patches submitted a week before the merge window opens are generally
>>> deferred to the next cycle. I expect that once -rc1 is out, Gregory
>>> will pick up this patch.
>>
>> These are real bugfixes, I want them in 4.15, since we now get a
>> loud warning for them. I'd rather not shut up that warning because
>> it's not a false-positive.
>
> As pointed by Andrew, I planned to take them once the 4.15-rc1 would be
> released. It was not obvious for me that it was real fixes. Actually I
> would have expected to have first the dts fixed in a release and then
> the warning enabled.

I didn't plan to fix everyone's warnings for them. Unfortunately, the
combination of linux-next being infrequent in Oct and kernelci.org
failing to report dtc warnings caused all the warnings started to get
noticed late, so I fixed the noisier cases. The only way anyone pays
attention is when dtc is updated and warnings appear. I've emailed out
warnings in advance before. I've turned off the more subjective ones
by default. Neither seems to get widely noticed (now in reviews
instead of saying "don't do X", I say "don't do X and building with
W=2 will tell you this"). More dtc checks are coming, so I'm open to
suggestions on the process.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olof Johansson Dec. 3, 2017, 12:49 a.m. | #9
On Tue, Nov 21, 2017 at 09:56:22PM +0100, Andrew Lunn wrote:
> On Thu, Nov 09, 2017 at 04:26:11PM -0600, Rob Herring wrote:
> > "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> > property. This is probably because the binding was the precursor to the phy
> > binding.
> > 
> > Fixes the following warning in Marvell dts files:
> > 
> > Warning (phys_property): Missing property '#phy-cells' in node ...
> > 
> > Signed-off-by: Rob Herring <robh@kernel.org>
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

I didn't see this come in before -rc1 and in current fixes, so given the acks
I've applied it directly now.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arnd Bergmann Dec. 7, 2017, 2:44 p.m. | #10
On Thu, Nov 9, 2017 at 11:26 PM, Rob Herring <robh@kernel.org> wrote:
> "usb-nop-xceiv" is using the phy binding, but is missing #phy-cells
> property. This is probably because the binding was the precursor to the phy
> binding.
>
> Fixes the following warning in nspire dts files:
>
> Warning (phys_property): Missing property '#phy-cells' in node ...
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Doesn't seem to be a maintainer for nspire. Arnd, please apply.

Applied to fixes, thanks!

       Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
index 5be01c859b7a..4dc6a8ee3071 100644
--- a/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
+++ b/Documentation/devicetree/bindings/usb/usb-nop-xceiv.txt
@@ -2,6 +2,7 @@  USB NOP PHY
 
 Required properties:
 - compatible: should be usb-nop-xceiv
+- #phy-cells: Must be 0
 
 Optional properties:
 - clocks: phandle to the PHY clock. Use as per Documentation/devicetree
@@ -33,6 +34,7 @@  Example:
 		reset-gpios = <&gpio1 7 GPIO_ACTIVE_LOW>;
 		vbus-detect-gpio = <&gpio2 13 GPIO_ACTIVE_HIGH>;
 		vbus-regulator = <&vbus_regulator>;
+		#phy-cells = <0>;
 	};
 
 hsusb1_phy is a NOP USB PHY device that gets its clock from an oscillator