| Message ID | 1510228971-6005-1-git-send-email-sundeep.lkml@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Qemu,devel] MAINTAINERS: Add entries for Smartfusion2 | expand |
On Thu, Nov 9, 2017 at 4:02 AM, Subbaraya Sundeep <sundeep.lkml@gmail.com> wrote: > add voluntarily myself as maintainer for Smartfusion2 This should be: Voluntarily add myself as maintainer for Smartfusion2. > > Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com> With the commit message fixed: Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Alistair > --- > MAINTAINERS | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0cd4d02..dae08bd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -564,6 +564,23 @@ M: Alistair Francis <alistair@alistair23.me> > S: Maintained > F: hw/arm/netduino2.c > > +MSF2 SoC > +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> > +S: Maintained > +F: hw/arm/msf2-soc.c > +F: hw/misc/msf2-sysreg.c > +F: hw/timer/mss-timer.c > +F: hw/ssi/mss-spi.c > +F: include/hw/arm/msf2-soc.h > +F: include/hw/misc/msf2-sysreg.h > +F: include/hw/timer/mss-timer.h > +F: include/hw/ssi/mss-spi.h > + > +MSF2 SOM board > +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> > +S: Maintained > +F: hw/arm/msf2-som.c > + > CRIS Machines > ------------- > Axis Dev88 > -- > 2.5.0 >
Hi Subbaraya, On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: > add voluntarily myself as maintainer for Smartfusion2 You need to share your GnuPG key signed, I couldn't find it using http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep from https://wiki.qemu.org/Contribute/SubmitAPullRequest : All pull requests must be signed. If your key is not already signed by members of the QEMU community, you should make arrangements to attend a KeySigningParty (for example at KVM Forum) or make alternative arrangements to have your key signed by an attendee. Key signing requires meeting another community member *in person* so please make appropriate arrangements. IMHO it would be great you find some time to review some patches (qemu-arm@nongnu.org is not that verbose): https://wiki.qemu.org/Contribute/SubmitAPatch#Return_the_favor > > Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com> > --- > MAINTAINERS | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0cd4d02..dae08bd 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -564,6 +564,23 @@ M: Alistair Francis <alistair@alistair23.me> > S: Maintained > F: hw/arm/netduino2.c > > +MSF2 SoC SmartFusion2 > +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> > +S: Maintained > +F: hw/arm/msf2-soc.c > +F: hw/misc/msf2-sysreg.c > +F: hw/timer/mss-timer.c > +F: hw/ssi/mss-spi.c > +F: include/hw/arm/msf2-soc.h > +F: include/hw/misc/msf2-sysreg.h > +F: include/hw/timer/mss-timer.h > +F: include/hw/ssi/mss-spi.h > + Emcraft M2S-FG484 > +MSF2 SOM board > +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> > +S: Maintained > +F: hw/arm/msf2-som.c > + > CRIS Machines > ------------- > Axis Dev88 Regards, Phil.
On 9 November 2017 at 21:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > Hi Subbaraya, > > On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: >> add voluntarily myself as maintainer for Smartfusion2 > > You need to share your GnuPG key signed, I couldn't find it using > http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep > > from https://wiki.qemu.org/Contribute/SubmitAPullRequest : I don't in general expect to take pull requests from everybody listed as a maintainer in the MAINTAINERS file. That just means "I'm going to be reviewing and should be cc'd on patches". Pull requests are sent by people who are maintainers for a subsystem. Rule of thumb: unless somebody asks you to send a pull request, you don't need to do it. thanks -- PMM
On 11/09/2017 08:55 PM, Peter Maydell wrote: > On 9 November 2017 at 21:46, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> Hi Subbaraya, >> >> On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: >>> add voluntarily myself as maintainer for Smartfusion2 >> >> You need to share your GnuPG key signed, I couldn't find it using >> http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep >> >> from https://wiki.qemu.org/Contribute/SubmitAPullRequest : > > I don't in general expect to take pull requests from > everybody listed as a maintainer in the MAINTAINERS file. > That just means "I'm going to be reviewing and should > be cc'd on patches". Pull requests are sent by people > who are maintainers for a subsystem. Rule of thumb: > unless somebody asks you to send a pull request, you > don't need to do it. Ok, please apologize my misunderstanding. I still think the M: entry stand for 'Maintainer' instead of 'Mail', and still don't understand the difference with a "Designated reviewer" (R: entry): M: Mail patches to: FullName <address@domain> R: Designated reviewer: FullName <address@domain> These reviewers should be CCed on patches. "Designated reviewer" seems to duplicate the M: entry and is therefore confusing. Can we simply remove it instead? When introduced in fdf6fab4df4 the explanation was: -- Some people are not content with the amount of mail they get, and would like to be CCed on patches for areas they do not maintain. Let them satisfy their own appetite for qemu-devel messages. Seriously: the purpose here is a bit different from the Linux kernel. While Linux uses "R" to designate non-maintainers for reviewing patches in a given area, in QEMU I would also like to use "R" so that people can delegate sending pull requests while keeping some degree of oversight. -- Regards, Phil.
Hi Guys, On Fri, Nov 10, 2017 at 5:52 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > On 11/09/2017 08:55 PM, Peter Maydell wrote: > > On 9 November 2017 at 21:46, Philippe Mathieu-Daudé <f4bug@amsat.org> > wrote: > >> Hi Subbaraya, > >> > >> On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: > >>> add voluntarily myself as maintainer for Smartfusion2 > >> > >> You need to share your GnuPG key signed, I couldn't find it using > >> http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep > >> > >> from https://wiki.qemu.org/Contribute/SubmitAPullRequest : > > > > I don't in general expect to take pull requests from > > everybody listed as a maintainer in the MAINTAINERS file. > > That just means "I'm going to be reviewing and should > > be cc'd on patches". Pull requests are sent by people > > who are maintainers for a subsystem. Rule of thumb: > > unless somebody asks you to send a pull request, you > > don't need to do it. > > Ok, please apologize my misunderstanding. I still think the M: entry > stand for 'Maintainer' instead of 'Mail', and still don't understand the > difference with a "Designated reviewer" (R: entry): > > M: Mail patches to: FullName <address@domain> > R: Designated reviewer: FullName <address@domain> > These reviewers should be CCed on patches. > > "Designated reviewer" seems to duplicate the M: entry and is therefore > confusing. Can we simply remove it instead? > > When introduced in fdf6fab4df4 the explanation was: > > -- > Some people are not content with the amount of mail they get, and would > like to be CCed on patches for areas they do not maintain. Let them > satisfy their own appetite for qemu-devel messages. > > Seriously: the purpose here is a bit different from the Linux kernel. > While Linux uses "R" to designate non-maintainers for reviewing patches > in a given area, in QEMU I would also like to use "R" so that people can > delegate sending pull requests while keeping some degree of oversight. > Do you want me to remove M: and put only R: ? Thanks, Sundeep > -- > > Regards, > > Phil. >
Hi Sundeep, Peter. > On 11/09/2017 08:55 PM, Peter Maydell wrote: > > On 9 November 2017 at 21:46, Philippe Mathieu-Daudé <f4bug@amsat.org <mailto:f4bug@amsat.org>> wrote: > >> Hi Subbaraya, > >> > >> On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote: > >>> add voluntarily myself as maintainer for Smartfusion2 > >> > >> You need to share your GnuPG key signed, I couldn't find it using > >> http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep > <http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep> > >> > >> from https://wiki.qemu.org/Contribute/SubmitAPullRequest > <https://wiki.qemu.org/Contribute/SubmitAPullRequest> : > > > > I don't in general expect to take pull requests from > > everybody listed as a maintainer in the MAINTAINERS file. > > That just means "I'm going to be reviewing and should > > be cc'd on patches". Pull requests are sent by people > > who are maintainers for a subsystem. Rule of thumb: > > unless somebody asks you to send a pull request, you > > don't need to do it. > > Ok, please apologize my misunderstanding. I still think the M: entry Peter: Oops :) read "I apologize" > stand for 'Maintainer' instead of 'Mail', and still don't understand the > difference with a "Designated reviewer" (R: entry): > > M: Mail patches to: FullName <address@domain> > R: Designated reviewer: FullName <address@domain> > These reviewers should be CCed on patches. > > "Designated reviewer" seems to duplicate the M: entry and is therefore > confusing. Can we simply remove it instead? > > When introduced in fdf6fab4df4 the explanation was: > > -- > Some people are not content with the amount of mail they get, and would > like to be CCed on patches for areas they do not maintain. Let them > satisfy their own appetite for qemu-devel messages. > > Seriously: the purpose here is a bit different from the Linux kernel. > While Linux uses "R" to designate non-maintainers for reviewing patches > in a given area, in QEMU I would also like to use "R" so that people can > delegate sending pull requests while keeping some degree of oversight. > -- > > Do you want me to remove M: and put only R: ? No, it seems you are correct and I was wrong :) If you agree changing the first section title to "SmartFusion2" and eventually the second to "Emcraft M2S-FG484": Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Regards, Phil.
On 10 November 2017 at 00:22, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > On 11/09/2017 08:55 PM, Peter Maydell wrote: >> I don't in general expect to take pull requests from >> everybody listed as a maintainer in the MAINTAINERS file. >> That just means "I'm going to be reviewing and should >> be cc'd on patches". Pull requests are sent by people >> who are maintainers for a subsystem. Rule of thumb: >> unless somebody asks you to send a pull request, you >> don't need to do it. > > Ok, please apologize my misunderstanding. I still think the M: entry > stand for 'Maintainer' instead of 'Mail', and still don't understand the > difference with a "Designated reviewer" (R: entry): > > M: Mail patches to: FullName <address@domain> > R: Designated reviewer: FullName <address@domain> > These reviewers should be CCed on patches. > > "Designated reviewer" seems to duplicate the M: entry and is therefore > confusing. Can we simply remove it instead? I hadn't realized we had an 'R:' tag in MAINTAINERS... > -- > Some people are not content with the amount of mail they get, and would > like to be CCed on patches for areas they do not maintain. Let them > satisfy their own appetite for qemu-devel messages. > > Seriously: the purpose here is a bit different from the Linux kernel. > While Linux uses "R" to designate non-maintainers for reviewing patches > in a given area, in QEMU I would also like to use "R" so that people can > delegate sending pull requests while keeping some degree of oversight. > -- So, my view, based on what happens in practice: * "maintainer" means you are in effect accepting some responsibility for the continued maintenance of some bit of the codebase, ie you actually will review stuff * "reviewer" is a bit weird but I guess is just asking for cc: without promising to actually do anything * somebody who sends me pull requests is effectively somebody we've given the ability to make direct more-or-less unchecked commits to master, so that is given out more sparingly and for larger subsystems But MAINTAINERS is mostly about what submitters need to do (ie who to send patchmails to), so it doesn't particularly document how patches flow onward into master, which varies. (For instance the block layer folks have a two-level setup where some trees get merged into others before they go to master. ARM devboards go through me, and "maintainer" just means I let somebody else deal with the device specifics if possible but am still the reviewer of last resort.) thanks -- PMM
On 11/10/2017 09:56 AM, Peter Maydell wrote: > On 10 November 2017 at 00:22, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: >> On 11/09/2017 08:55 PM, Peter Maydell wrote: >>> I don't in general expect to take pull requests from >>> everybody listed as a maintainer in the MAINTAINERS file. >>> That just means "I'm going to be reviewing and should >>> be cc'd on patches". Pull requests are sent by people >>> who are maintainers for a subsystem. Rule of thumb: >>> unless somebody asks you to send a pull request, you >>> don't need to do it. >> >> Ok, please apologize my misunderstanding. I still think the M: entry >> stand for 'Maintainer' instead of 'Mail', and still don't understand the >> difference with a "Designated reviewer" (R: entry): >> >> M: Mail patches to: FullName <address@domain> >> R: Designated reviewer: FullName <address@domain> >> These reviewers should be CCed on patches. >> >> "Designated reviewer" seems to duplicate the M: entry and is therefore >> confusing. Can we simply remove it instead? > > I hadn't realized we had an 'R:' tag in MAINTAINERS... > >> -- >> Some people are not content with the amount of mail they get, and would >> like to be CCed on patches for areas they do not maintain. Let them >> satisfy their own appetite for qemu-devel messages. >> >> Seriously: the purpose here is a bit different from the Linux kernel. >> While Linux uses "R" to designate non-maintainers for reviewing patches >> in a given area, in QEMU I would also like to use "R" so that people can >> delegate sending pull requests while keeping some degree of oversight. >> -- > > So, my view, based on what happens in practice: > * "maintainer" means you are in effect accepting some responsibility > for the continued maintenance of some bit of the codebase, ie > you actually will review stuff > * "reviewer" is a bit weird but I guess is just asking for cc: > without promising to actually do anything > * somebody who sends me pull requests is effectively somebody we've > given the ability to make direct more-or-less unchecked commits > to master, so that is given out more sparingly and for larger > subsystems Thanks for clarifying this! This is more understandable (to me) than the "QEMU Maintainers" section entries description. > But MAINTAINERS is mostly about what submitters need to do (ie > who to send patchmails to), so it doesn't particularly document > how patches flow onward into master, which varies. (For instance > the block layer folks have a two-level setup where some trees > get merged into others before they go to master. ARM devboards > go through me, and "maintainer" just means I let somebody else > deal with the device specifics if possible but am still the > reviewer of last resort.) Ok :) Regards, Phil.
Hi, On Fri, Nov 10, 2017 at 7:10 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > On 11/10/2017 09:56 AM, Peter Maydell wrote: > > On 10 November 2017 at 00:22, Philippe Mathieu-Daudé <f4bug@amsat.org> > wrote: > >> On 11/09/2017 08:55 PM, Peter Maydell wrote: > >>> I don't in general expect to take pull requests from > >>> everybody listed as a maintainer in the MAINTAINERS file. > >>> That just means "I'm going to be reviewing and should > >>> be cc'd on patches". Pull requests are sent by people > >>> who are maintainers for a subsystem. Rule of thumb: > >>> unless somebody asks you to send a pull request, you > >>> don't need to do it. > >> > >> Ok, please apologize my misunderstanding. I still think the M: entry > >> stand for 'Maintainer' instead of 'Mail', and still don't understand the > >> difference with a "Designated reviewer" (R: entry): > >> > >> M: Mail patches to: FullName <address@domain> > >> R: Designated reviewer: FullName <address@domain> > >> These reviewers should be CCed on patches. > >> > >> "Designated reviewer" seems to duplicate the M: entry and is therefore > >> confusing. Can we simply remove it instead? > > > > I hadn't realized we had an 'R:' tag in MAINTAINERS... > > > >> -- > >> Some people are not content with the amount of mail they get, and would > >> like to be CCed on patches for areas they do not maintain. Let them > >> satisfy their own appetite for qemu-devel messages. > >> > >> Seriously: the purpose here is a bit different from the Linux kernel. > >> While Linux uses "R" to designate non-maintainers for reviewing patches > >> in a given area, in QEMU I would also like to use "R" so that people can > >> delegate sending pull requests while keeping some degree of oversight. > >> -- > > > > So, my view, based on what happens in practice: > > * "maintainer" means you are in effect accepting some responsibility > > for the continued maintenance of some bit of the codebase, ie > > you actually will review stuff > > * "reviewer" is a bit weird but I guess is just asking for cc: > > without promising to actually do anything > > * somebody who sends me pull requests is effectively somebody we've > > given the ability to make direct more-or-less unchecked commits > > to master, so that is given out more sparingly and for larger > > subsystems > > Thanks for clarifying this! > Thanks Peter, Philippe and Alistair, Sundeep > This is more understandable (to me) than the "QEMU Maintainers" section > entries description. > > > But MAINTAINERS is mostly about what submitters need to do (ie > > who to send patchmails to), so it doesn't particularly document > > how patches flow onward into master, which varies. (For instance > > the block layer folks have a two-level setup where some trees > > get merged into others before they go to master. ARM devboards > > go through me, and "maintainer" just means I let somebody else > > deal with the device specifics if possible but am still the > > reviewer of last resort.) > > Ok :) > > Regards, > > Phil. >
diff --git a/MAINTAINERS b/MAINTAINERS index 0cd4d02..dae08bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -564,6 +564,23 @@ M: Alistair Francis <alistair@alistair23.me> S: Maintained F: hw/arm/netduino2.c +MSF2 SoC +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> +S: Maintained +F: hw/arm/msf2-soc.c +F: hw/misc/msf2-sysreg.c +F: hw/timer/mss-timer.c +F: hw/ssi/mss-spi.c +F: include/hw/arm/msf2-soc.h +F: include/hw/misc/msf2-sysreg.h +F: include/hw/timer/mss-timer.h +F: include/hw/ssi/mss-spi.h + +MSF2 SOM board +M: Subbaraya Sundeep <sundeep.lkml@gmail.com> +S: Maintained +F: hw/arm/msf2-som.c + CRIS Machines ------------- Axis Dev88
add voluntarily myself as maintainer for Smartfusion2 Signed-off-by: Subbaraya Sundeep <sundeep.lkml@gmail.com> --- MAINTAINERS | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)