[1/1,SRU,X/Z/A] ALSA: usb-audio: Add sample rate quirk for Plantronics P610

Message ID 20171109093328.30303-2-kai.heng.feng@canonical.com
State New
Headers show
Series
  • Forbid ALSA reads sample rate on Plantronics P610
Related show

Commit Message

Kai Heng Feng Nov. 9, 2017, 9:33 a.m.
Like other Plantronics devices, P610 does not support sample
rate reading. Apply sample rate quirk to it.

BugLink: https://bugs.launchpad.net/bugs/1719853

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kleber Sacilotto de Souza Nov. 15, 2017, 11:02 a.m. | #1
On 11/09/17 10:33, Kai-Heng Feng wrote:
> Like other Plantronics devices, P610 does not support sample
> rate reading. Apply sample rate quirk to it.
> 
> BugLink: https://bugs.launchpad.net/bugs/1719853
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index c0b86f77755c..dcfe6669c362 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>  	case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
>  	case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>  	case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
> +	case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
>  	case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
>  	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>  	case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
>
Stefan Bader Nov. 15, 2017, 2:08 p.m. | #2
On 09.11.2017 10:33, Kai-Heng Feng wrote:
> Like other Plantronics devices, P610 does not support sample
> rate reading. Apply sample rate quirk to it.
> 
> BugLink: https://bugs.launchpad.net/bugs/1719853
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit c247487c0dd6fefff6ed0cbcbe66f037721755fb)
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>

> ---

Patch looks ok but could you copy the sru justification into the bug report
subject? Thanks.

-Stefan

>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index c0b86f77755c..dcfe6669c362 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>  	case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
>  	case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
>  	case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
> +	case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
>  	case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
>  	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
>  	case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
>

Patch

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index c0b86f77755c..dcfe6669c362 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1139,6 +1139,7 @@  bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
 	case USB_ID(0x047F, 0x0415): /* Plantronics BT-300 */
 	case USB_ID(0x047F, 0xAA05): /* Plantronics DA45 */
 	case USB_ID(0x047F, 0xC022): /* Plantronics C310 */
+	case USB_ID(0x047F, 0xC02F): /* Plantronics P610 */
 	case USB_ID(0x047F, 0xC036): /* Plantronics C520-M */
 	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
 	case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */