[3/3] orangepi-pc-plus: enable WiFi support

Message ID 20171108194334.10031-4-geomatsi@gmail.com
State Accepted
Headers show
Series
  • orangepi_pc_plus: new board and its drivers
Related show

Commit Message

Sergey Matyukevich Nov. 8, 2017, 7:43 p.m.
Make WiFi work out of the box on orangepi-pc-plus:
  - add rtl8xx firmware
  - add rtl8189fs driver
  - add mdev for module autoloading

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---
 configs/orangepi_pc_plus_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni Dec. 3, 2017, 10:33 p.m. | #1
Hello,

On Wed,  8 Nov 2017 22:43:34 +0300, Sergey Matyukevich wrote:
> Make WiFi work out of the box on orangepi-pc-plus:
>   - add rtl8xx firmware
>   - add rtl8189fs driver
>   - add mdev for module autoloading
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
>  configs/orangepi_pc_plus_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master, thanks.

Thomas
Jagan Teki Dec. 4, 2017, 4:25 a.m. | #2
On Thu, Nov 9, 2017 at 1:13 AM, Sergey Matyukevich <geomatsi@gmail.com> wrote:
> Make WiFi work out of the box on orangepi-pc-plus:
>   - add rtl8xx firmware
>   - add rtl8189fs driver
>   - add mdev for module autoloading
>
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
>  configs/orangepi_pc_plus_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/configs/orangepi_pc_plus_defconfig b/configs/orangepi_pc_plus_defconfig
> index ec177286cc..b06b9b1005 100644
> --- a/configs/orangepi_pc_plus_defconfig
> +++ b/configs/orangepi_pc_plus_defconfig
> @@ -1,6 +1,7 @@
>  BR2_arm=y
>  BR2_cortex_a7=y
>  BR2_ARM_FPU_VFPV4=y
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_13=y
>  BR2_TARGET_GENERIC_HOSTNAME="OrangePi_PC_Plus"
>  BR2_TARGET_GENERIC_ISSUE="Welcome to Buildroot for the Orange Pi PC Plus"
> @@ -29,6 +30,11 @@ BR2_PACKAGE_HOST_GENIMAGE=y
>  BR2_PACKAGE_HOST_MTOOLS=y
>  BR2_PACKAGE_HOST_UBOOT_TOOLS=y
>
> +# wireless driver and firmware
> +BR2_PACKAGE_RTL8189FS=y
> +BR2_PACKAGE_LINUX_FIRMWARE=y
> +BR2_PACKAGE_LINUX_FIRMWARE_RTL_81XX=y
> +

I'm trying to understand here about minimal defconfig vs custom
selection of packages, like adding qt5 on this patch[1]. Does wifi
here not considered as custom config? if ie true if should be
orangepi_pc_plus_wif_defconfig?

[1] https://patchwork.ozlabs.org/patch/839237/

thanks!
Thomas Petazzoni Dec. 4, 2017, 7:59 a.m. | #3
Hello,

On Mon, 4 Dec 2017 09:55:53 +0530, Jagan Teki wrote:

> > +# wireless driver and firmware
> > +BR2_PACKAGE_RTL8189FS=y
> > +BR2_PACKAGE_LINUX_FIRMWARE=y
> > +BR2_PACKAGE_LINUX_FIRMWARE_RTL_81XX=y
> > +  
> 
> I'm trying to understand here about minimal defconfig vs custom
> selection of packages, like adding qt5 on this patch[1]. Does wifi
> here not considered as custom config? if ie true if should be
> orangepi_pc_plus_wif_defconfig?

As usual, the boundaries are not 100% strict and fixed. However, we
have considered for a number of boards that have WiFi support that it
makes sense to enable the relevant driver and firmware to enable WiFi.

This is quite different from Qt5: for WiFi, there is basically no other
option than using this firmware and this driver. For graphics, you may
want to use Qt5. But you may also want to use X11, or Wayland/Weston,
or, etc. So Qt5 is a lot less "the obvious thing that everybody will
obviously want to use on this board".

Also, installing this firmware file and building this driver probably
adds 20 seconds to the build time of the defconfig. It's not exactly
the same for Qt5 :-)

Best regards,

Thomas

Patch

diff --git a/configs/orangepi_pc_plus_defconfig b/configs/orangepi_pc_plus_defconfig
index ec177286cc..b06b9b1005 100644
--- a/configs/orangepi_pc_plus_defconfig
+++ b/configs/orangepi_pc_plus_defconfig
@@ -1,6 +1,7 @@ 
 BR2_arm=y
 BR2_cortex_a7=y
 BR2_ARM_FPU_VFPV4=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_13=y
 BR2_TARGET_GENERIC_HOSTNAME="OrangePi_PC_Plus"
 BR2_TARGET_GENERIC_ISSUE="Welcome to Buildroot for the Orange Pi PC Plus"
@@ -29,6 +30,11 @@  BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
 BR2_PACKAGE_HOST_UBOOT_TOOLS=y
 
+# wireless driver and firmware
+BR2_PACKAGE_RTL8189FS=y
+BR2_PACKAGE_LINUX_FIRMWARE=y
+BR2_PACKAGE_LINUX_FIRMWARE_RTL_81XX=y
+
 # wireless tools
 BR2_PACKAGE_IW=y
 BR2_PACKAGE_WIRELESS_TOOLS=y