Patchwork PATCH committed: 64-bit Apple Objective-C runtime support

login
register
mail settings
Submitter Nicola Pero
Date Feb. 18, 2011, 1:26 p.m.
Message ID <1298035570.039823109@192.168.4.58>
Download mbox | patch
Permalink /patch/83590/
State New
Headers show

Comments

Nicola Pero - Feb. 18, 2011, 1:26 p.m.
Jack,

thanks for testing this out.  You can xfail these.  Iain sent me this
morning an additional patch that xfails these; he must have forgotten
to include it in the original one.

I'll attach it.  I can't commit now; if Mike or you have time, please do.
I understand that the patch is pre-approved by Mike.

Else, I'll commit it myself tonight (GMT).  Apologies for the temporary
noise on the m64 testsuite on Darwin.

Thanks

-----Original Message-----
From: "Jack Howarth" <howarth@bromo.med.uc.edu>
Sent: Friday, 18 February, 2011 14:10
To: "Mike Stump" <mikestump@comcast.net>
Cc: gcc-patches@gnu.org, "GCC Development" <gcc@gcc.gnu.org>
Subject: Re: PATCH committed: 64-bit Apple Objective-C runtime support

On Thu, Feb 17, 2011 at 06:21:17PM -0800, Mike Stump wrote:
> On Feb 17, 2011, at 4:09 PM, Nicola Pero wrote:
> > This patch is not me - it's by Iain Sandoe. :-)
> 
> Thanks for chipping in and helping out.  I'm excited at having a Objective-C compiler that works again on darwin.
> 
> That said, if people have any Objective-C codes, feel free to beat on them and let us know what you find.  We're interested in regressions first and foremost, after that functionality on 64-bit darwin.  We know about PCH not working well in some situations, so, be prepared to turn that off.

  Did Iain see these failures in his testing at -m64?

FAIL: objc/execute/exceptions/foward-1.m execution,  -O0 -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O1 -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O2 -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O3 -fomit-frame-pointer -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O3 -fomit-frame-pointer -funroll-loops -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -O3 -g -fnext-runtime
FAIL: objc/execute/exceptions/foward-1.m execution,  -Os -fnext-runtime

I am seeing those on x86_64-apple-darwin10.
                 Jack

Patch

Index: gcc/testsuite/objc/execute/exceptions/foward-1.x

===================================================================
--- gcc/testsuite/objc/execute/exceptions/foward-1.x	(revision 0)

+++ gcc/testsuite/objc/execute/exceptions/foward-1.x	(revision 0)

@@ -0,0 +1,11 @@ 

+# XFAIL the run for m64 Darwin NeXT (seems to be a system runtime lib problem).

+if { [istarget *-*-darwin*] && [check_effective_target_lp64] } {

+    set torture_eval_before_execute {

+        global compiler_conditional_xfail_data

+        set compiler_conditional_xfail_data {

+          "Target fails for fnext-runtime" "*-*-*" { "-fnext-runtime" } { "" }

+        }

+    }

+}

+# carry on...

+return false