diff mbox series

[net] net: dsa: return after mdb prepare phase

Message ID 20171108154956.23898-1-vivien.didelot@savoirfairelinux.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net] net: dsa: return after mdb prepare phase | expand

Commit Message

Vivien Didelot Nov. 8, 2017, 3:49 p.m. UTC
The current code does not return after successfully preparing the MDB
addition on every ports member of a multicast group. Fix this.

Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support")
Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 net/dsa/switch.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Lunn Nov. 8, 2017, 3:52 p.m. UTC | #1
On Wed, Nov 08, 2017 at 10:49:56AM -0500, Vivien Didelot wrote:
> The current code does not return after successfully preparing the MDB
> addition on every ports member of a multicast group. Fix this.
> 
> Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support")
> Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller Nov. 11, 2017, 6:45 a.m. UTC | #2
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Wed,  8 Nov 2017 10:49:56 -0500

> The current code does not return after successfully preparing the MDB
> addition on every ports member of a multicast group. Fix this.
> 
> Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support")
> Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Applied.
diff mbox series

Patch

diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index e6c06aa349a6..73746fa148f1 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -133,6 +133,8 @@  static int dsa_switch_mdb_add(struct dsa_switch *ds,
 			if (err)
 				return err;
 		}
+
+		return 0;
 	}
 
 	for_each_set_bit(port, group, ds->num_ports)